Ensure nodeSelector logic is consistent for all operators

[olliewalsh]

nodeSelectors are not currently applied consistently across all operators.

Some do not support nodeSelectors at all - will be implemented in this series of pull requests.
Some do not apply them to every pod (jobs/cronjobs esp) - will be resolved in this series of pull requests.
Some do not apply a node selector update correctly, only when not initially set.
Some support nodeSelectors but do not inherit the default nodeSelector from the OpenstackControlPlane CR.

Jira: OSPRH-10734

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/48ad8b05e53046db94dd79071e959f22

❌ openstack-k8s-operators-content-provider FAILURE in 14m 10s
⚠️ manila-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)
⚠️ manila-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)

[olliewalsh]

/override ci/prow/manila-operator-build-deploy-kuttl ci/prow/manila-operator-build-deploy-tempest rdoproject.org/github-check

[openshift-ci]

@olliewalsh: Overrode contexts on behalf of olliewalsh: ci/prow/manila-operator-build-deploy-kuttl, ci/prow/manila-operator-build-deploy-tempest, rdoproject.org/github-check

In response to this:

/override ci/prow/manila-operator-build-deploy-kuttl ci/prow/manila-operator-build-deploy-tempest rdoproject.org/github-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[abays]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, olliewalsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [abays,olliewalsh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[olliewalsh]

/cherry-pick 18.0-fr1

[openshift-cherrypick-robot]

@olliewalsh: new pull request created: #361

In response to this:

/cherry-pick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tosky]

The content-provider job now complains with

    [1/2] STEP 14/15: RUN if [ -f $CACHITO_ENV_FILE ] ; then source $CACHITO_ENV_FILE ; fi ; env ${GO_BUILD_EXTRA_ENV_ARGS} go build ${GO_BUILD_EXTRA_ARGS} -a -o ${DEST_ROOT}/manager main.go
    # github.com/openstack-k8s-operators/openstack-operator/pkg/openstack
    pkg/openstack/manila.go:110:48: cannot use &instance.Spec.NodeSelector (value of type *map[string]string) as map[string]string value in assignment
    Error: building at STEP "RUN if [ -f $CACHITO_ENV_FILE ] ; then source $CACHITO_ENV_FILE ; fi ; env ${GO_BUILD_EXTRA_ENV_ARGS} go build ${GO_BUILD_EXTRA_ARGS} -a -o ${DEST_ROOT}/manager main.go": while running runtime: exit status 1
    make: *** [Makefile:209: docker-build] Error 1