Consume Topology CR by reference #385
Conversation
fmount
requested review from
fultonj
and removed request for
dprince and
viroel
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmount The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fmount
force-pushed
the
topologyref
branch
5 times, most recently
from
6db6f27 to
855fc97
Compare
|
/test manila-operator-build-deploy-kuttl |
1 similar comment
|
/test manila-operator-build-deploy-kuttl |
|
The kuttl failure looks really weird. I think it might be related to some timing issue between multiple set of test execution: The assert fails with the following: but from the must-gather we can see the DBSync job is over and Pods are up. I'm wondering if we need a bigger timeout to let the assert watch at the last results and move forward. |
fmount
force-pushed
the
topologyref
branch
2 times, most recently
from
6442a12 to
1a10752
Compare
|
/test manila-operator-build-deploy-tempest |
|
I might need to update this patch on top of openstack-k8s-operators/lib-common#597, /holding it for now. |
|
/retest |
fmount
force-pushed
the
topologyref
branch
2 times, most recently
from
10aeb9e to
8f4e092
Compare
This patch provides more granular control over Pod placement and scheduling through the Topology CR integration introduced in [1]. In particular it provides: - a new API parameter (TopologyRef) defined for each Component that allows to reference an existing Topology CRs in the same namespace - the operator logic that retrieves and processes the referenced Topology CR through the functions provided by lib-common [2] - an enhanced StatefulSet configuration that incorporates the processed Topology - a set of envTest to test the lifecycle (add/update/override/remove) of the resulting StatefulSets when a Topology is referenced Note that webhooks are in place to prevent referencing a Topology from a different namespace (which is not a supported scenario). Signed-off-by: Francesco Pantano <[email protected]>
|
@fmount: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This patch introduces a more granular control over
Podplacement andschedulingthrough theTopologyCR integration introduced in [1].In particular it provides:
APIparameter (TopologyRef) defined for each Component that allows to reference an existingTopology CRin the same namespaceTopology CRthrough the functions provided bylib-common[2]StatefulSetconfiguration that incorporates the processedTopologyenvTestto test the lifecycle (add/update/override/remove) of the resultingStatefulSetwhen aTopologyis referencedNote that
webhooksare in place to prevent referencing aTopologyfrom a different namespace (which is not a supported scenario).