Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ProxyPreserveHost directive to "on" in the httpd container #292

Merged

Conversation

slawqo
Copy link
Contributor

@slawqo slawqo commented Jan 30, 2024

We need to pass original host from the API requests incomining to the neutron api server e.g. in order to have proper pagination links returned.

Closes: OSPRH-3099

@openshift-ci openshift-ci bot requested review from dprince and olliewalsh January 30, 2024 14:41
Copy link
Contributor

openshift-ci bot commented Jan 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slawqo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karelyatin
Copy link
Contributor

/lgtm

Job results should confirm it too

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/dc93fb69153e429b8204ca4570a9e929

openstack-k8s-operators-content-provider FAILURE in 11m 24s
⚠️ neutron-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@karelyatin
Copy link
Contributor

seems need to rebase for the current failures

We need to pass original host from the API requests incomining to the
neutron api server e.g. in order to have proper pagination links
returned.

Closes: OSPRH-3099
@openshift-ci openshift-ci bot removed the lgtm label Jan 30, 2024
@booxter
Copy link
Contributor

booxter commented Jan 30, 2024

/lgtm

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/0f05631574b54e2886e15b15e6d72a7f

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 39m 08s
neutron-operator-tempest-multinode FAILURE in 1h 20m 01s

@slawqo
Copy link
Contributor Author

slawqo commented Jan 30, 2024

recheck - some unrelated EDPM error

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/20d2867d146c43279c2afb1df709863d

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 38m 31s
neutron-operator-tempest-multinode FAILURE in 1h 18m 43s

@karelyatin
Copy link
Contributor

recheck edpm issue should be fixed now with openstack-k8s-operators/openstack-operator#644

@openshift-merge-bot openshift-merge-bot bot merged commit 45ee00d into openstack-k8s-operators:main Jan 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants