Escape password for tempest conf #863
Conversation
In openstack-k8s-operators/tcib@9258ba0 eval was introduced and password for cirros start returning an error
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrkisaolamb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
they do know that eval is generally considered a security risk and that probably should be reverted right... |
| @@ -112,9 +112,9 @@ | |||
| service_available.swift false | |||
| service_available.cinder false | |||
| validation.image_ssh_user cirros | |||
| validation.image_ssh_password cubswin:) | |||
| validation.image_ssh_password cubswin:\) | |||
There was a problem hiding this comment.
i think this can be validation.image_ssh_password 'cubswin:)'
if we read the commit they are saying
Use 'eval' to expand the TEMPESTCONF_OVERRIDES variable prior to
using it to run discover-tempest-config. This prevents embedded
quotes within the variable from being mangled.
Without the 'eval' embedded quoted strings like "Some String" get
mangled into '"Some' 'String"' on the resulting command line.
that would imply we should just be able to quote it to prevent having to escape anyting
There was a problem hiding this comment.
I tried eval locally with "cubswin:)" and unfortunatly return error, problem is with bash: syntax error near unexpected token `)'
There was a problem hiding this comment.
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2f73048bad764d30a19c82de513fd543 ✔️ openstack-meta-content-provider SUCCESS in 4h 19m 26s |
|
I prefer openstack-k8s-operators/tcib#212 as that is a global solution |
|
agree, closing |
In openstack-k8s-operators/tcib@9258ba0 eval was introduced and password for cirros start
returning an error