Cert management #204
Cert management #204
Conversation
|
Skipping CI for Draft Pull Request. |
| caPassSecret, _, err := secret.GetSecret( | ||
| ctx, helper, instance.Spec.CAKeyPassphrasesSecret, instance.Namespace) | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
Not sure how to handle that case.
weinimo
force-pushed
the
cert-management
branch
from
1c61822 to
cc234e7
Compare
weinimo
force-pushed
the
cert-management
branch
from
0604aa1 to
328a8a0
Compare
weinimo
force-pushed
the
cert-management
branch
from
328a8a0 to
17dee94
Compare
|
/unapprove |
|
/remove-approve |
|
|
||
| var ( | ||
| // Files get mounted as root:root, but process is running as octavia | ||
| configMode int32 = 0644 |
There was a problem hiding this comment.
I think this is okay for now but we should look at if its possible to mount as the octavia user.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: beagles The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
||
| var ( | ||
| subjectDefault = pkix.Name{ | ||
| Organization: []string{"Dis"}, |
There was a problem hiding this comment.
do we have this for backward compatibility with existing load balancers?
There was a problem hiding this comment.
It is what TripleO used. Not sure if it is needed for backwards compatibility, but I figured it is better to use what we know is working.
| @@ -0,0 +1,215 @@ | |||
| package amphoracontrollers | |||
There was a problem hiding this comment.
FIXME: add license text
|
/hold |
|
/hold cancel |
openshift-merge-bot
bot
merged commit f7663b9
into
openstack-k8s-operators:main
Seemed functioning before I did the rebase, but I couldn't fully test it yet.