Preventing CLI command injection in a debug mode #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
jpodivin
changed the title
|
recheck |
|
/retest |
log message announcing that the operator is running in a debug mode. Kuttl tests were expanded to cover the new edge case and original test cases were adjusted to unify their structure. Signed-off-by: Jiri Podivin <[email protected]>
jpodivin
changed the title
fao89
approved these changes
Jul 31, 2023
| @@ -299,6 +299,7 @@ func (r *OpenStackAnsibleEEReconciler) jobForOpenStackAnsibleEE( | |||
| // Override args list if we are in a debug mode | |||
| if instance.Spec.Debug { | |||
| args = []string{"sleep", "1d"} | |||
| r.Log.Info(fmt.Sprintf("Instance %s will be running in debug mode.", instance.Name)) | |||
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fao89, jpodivin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit a1bb25e
into
openstack-k8s-operators:main
2 checks passed
danpawlik
pushed a commit
to danpawlik/openstack-ansibleee-operator
that referenced
this pull request
Oct 12, 2023
…rators/fix_edpm Use Local storage in EDPM CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also sets up a log message announcing that the operator is running in a debug mode and expands the test coverage.
I did forget about an edge case that may cause problems down the line. I haven't seen any yet, but I would rather err on the side of caution here.