Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report when backoff limit is exceeded #356

Merged
merged 2 commits into from
May 28, 2024
Merged

Report when backoff limit is exceeded #356

merged 2 commits into from
May 28, 2024

Conversation

fao89
Copy link
Contributor

@fao89 fao89 commented May 7, 2024 •
edited
Loading

No description provided.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 7, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved label May 7, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

This change depends on a change that failed to merge.

Change openstack-k8s-operators/lib-common#504 is needed.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/bb864fab15224f20be8bb2680999c8a1

❌ openstack-k8s-operators-content-provider FAILURE in 7m 38s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ ansibleee-operator-docs-preview SUCCESS in 3m 00s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/b412691b34b0447481d27817665466f8

❌ openstack-k8s-operators-content-provider FAILURE in 8m 28s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ ansibleee-operator-docs-preview SUCCESS in 2m 24s

fao89 added a commit to fao89/dataplane-operator that referenced this pull request May 8, 2024
@fao89
Track retries and backoff limit
b0674d0 
Depends-On: openstack-k8s-operators/openstack-ansibleee-operator#356
Signed-off-by: Fabricio Aguiar <[email protected]>
@fao89 fao89 mentioned this pull request May 8, 2024
Merged
fao89 added a commit to fao89/dataplane-operator that referenced this pull request May 9, 2024
@fao89
Track retries and backoff limit
9bbeafd 
Depends-On: openstack-k8s-operators/openstack-ansibleee-operator#356

Signed-off-by: Fabricio Aguiar <[email protected]>
@fao89 fao89 marked this pull request as ready for review May 22, 2024 14:24
@openshift-ci openshift-ci bot requested review from jpodivin and stuggi May 22, 2024 14:25
@fao89 fao89 force-pushed the joberr branch 2 times, most recently from 447190e to 15b8daf Compare May 22, 2024 14:59
@fao89
Copy link
Contributor Author

fao89 commented May 22, 2024

/test functional

@fao89 fao89 mentioned this pull request May 22, 2024
Merged
@fao89
Copy link
Contributor Author

fao89 commented May 22, 2024

/test functional

1 similar comment
@fao89
Copy link
Contributor Author

fao89 commented May 22, 2024

/test functional

jpodivin

This comment was marked as resolved.

Sign in to view

jpodivin
jpodivin reviewed May 23, 2024
View reviewed changes
Copy link
Contributor

@jpodivin jpodivin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the Failed going to be used in any other way besides providing information if one calls up the resource from client? Any plans for it to be involved in operator behavior for example?

@fao89
Copy link
Contributor Author

fao89 commented May 23, 2024

Is the Failed going to be used in any other way besides providing information if one calls up the resource from client? Any plans for it to be involved in operator behavior for example?

yes, it will be used here: https://github.com/openstack-k8s-operators/dataplane-operator/pull/879/files for tracking the attempts on the dataplane-operator side

@fao89
Use conditions from lib-common
c6e11d8 
Signed-off-by: Fabricio Aguiar <[email protected]>
fao89 added a commit to fao89/dataplane-operator that referenced this pull request May 28, 2024
@fao89
Expose the backoff limit
5d42463 
Depends-On: openstack-k8s-operators/openstack-ansibleee-operator#356

Signed-off-by: Fabricio Aguiar <[email protected]>
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/9797ddad5e104d45aff43b9cc2ef866f

❌ openstack-k8s-operators-content-provider FAILURE in 12m 27s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ ansibleee-operator-docs-preview SUCCESS in 2m 19s

@fao89
Copy link
Contributor Author

fao89 commented May 28, 2024

recheck

fao89 added a commit to fao89/dataplane-operator that referenced this pull request May 28, 2024
@fao89
Expose the backoff limit
65cf17c 
Depends-On: openstack-k8s-operators/openstack-ansibleee-operator#356

Signed-off-by: Fabricio Aguiar <[email protected]>
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/f8297aad5b4c43a599dcdfea5a9262d0

✔️ openstack-k8s-operators-content-provider SUCCESS in 28m 25s
❌ podified-multinode-edpm-deployment-crc RETRY_LIMIT in 4s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 4s
✔️ ansibleee-operator-docs-preview SUCCESS in 5m 19s

@fao89
Copy link
Contributor Author

fao89 commented May 28, 2024

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/9ce9c1132b7242acb650dde445f1d521

❌ openstack-k8s-operators-content-provider FAILURE in 13m 15s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ ansibleee-operator-docs-preview SUCCESS in 3m 52s

@fao89
Copy link
Contributor Author

fao89 commented May 28, 2024

recheck

@fao89 fao89 requested review from jpodivin and rabi May 28, 2024 15:20
@openshift-ci openshift-ci bot added the lgtm label May 28, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fao89, slagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit bc8fc0a into openstack-k8s-operators:main May 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slagle slagle slagle approved these changes

@stuggi stuggi Awaiting requested review from stuggi

@jpodivin jpodivin Awaiting requested review from jpodivin

@rabi rabi Awaiting requested review from rabi

Assignees

@slagle slagle

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fao89 @rabi @slagle @jpodivin