Don't set default for optional CtlplaneNetmask #241
Conversation
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/aede651eb3d449eaafd46ba7dd3c6692 ❌ openstack-baremetal-operator-content-provider FAILURE in 7m 30s |
bshephar
force-pushed
the
no-default-netmask
branch
from
fc75931 to
9916426
Compare
|
/test openstack-baremetal-operator-build-deploy |
| @@ -88,7 +88,6 @@ type OpenStackBaremetalSetSpec struct { | |||
| // +kubebuilder:validation:Optional | |||
| CtlplaneGateway string `json:"ctlplaneGateway,omitempty"` | |||
| // +kubebuilder:validation:Optional | |||
| // +kubebuilder:default="255.255.255.0" | |||
There was a problem hiding this comment.
We should remove this from API as it's not used anymore. Was left behind[1] to not break any usage. I think we can safely remove this.
[1] https://github.com/openstack-k8s-operators/openstack-baremetal-operator/blob/main/pkg/openstackbaremetalset/baremetalhost.go#L102
There was a problem hiding this comment.
ack, let's remove it
bshephar
force-pushed
the
no-default-netmask
branch
from
9916426 to
f3ff42b
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bshephar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3425573c7335423d83e6ba6a4eaa0523 ❌ openstack-baremetal-operator-content-provider FAILURE in 6m 55s |
|
/retest |
There was a problem hiding this comment.
You also have to remove https://github.com/openstack-k8s-operators/openstack-baremetal-operator/blob/main/pkg/openstackbaremetalset/baremetalhost.go#L102 where instance.Spec.CtlplaneNetmask is used.
| @@ -139,7 +139,6 @@ spec: | |||
| to use for ctlplane network | |||
| type: string | |||
| ctlplaneNetmask: | |||
There was a problem hiding this comment.
You've to regenerate these, else pre-commit and other jobs would fail.
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f97fde84bff542feb904c45d0d8c6db9 ❌ openstack-baremetal-operator-content-provider FAILURE in 12m 18s |
|
/test openstack-baremetal-operator-build-deploy |
This change removes the CtlplaneNetmask parameter since it is not required since we're using CIDR's. Signed-off-by: Brendan Shephard <[email protected]>
Signed-off-by: Brendan Shephard <[email protected]>
bshephar
force-pushed
the
no-default-netmask
branch
from
0e8304a to
ff31cd9
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bbdae48fe81d4606ba491a9c4c86e9ee ❌ openstack-baremetal-operator-content-provider FAILURE in 12m 13s |
|
@bshephar: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This change removes use of CtlplaneNetmask in line with the changes proposed in: openstack-k8s-operators/openstack-baremetal-operator#241 Signed-off-by: Brendan Shephard <[email protected]>
|
I think we probably need to go with the original plan of making this param optional. Then we can remove it from openstack-operator, then we can remove it from here. |
jira: https://issues.redhat.com/browse/OSPRH-12304