Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mysqld exporter #1236

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vyzigold
Copy link
Contributor

This adds support for deploying the mysqld exporter as part of ceilometer CR. This is very similar to #1056

Depends-On: openstack-k8s-operators/telemetry-operator#571

Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vyzigold
Once this PR has been reviewed and has the lgtm label, please assign dprince for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vyzigold
Copy link
Contributor Author

I saw that there were some concerns by @dprince on the KSM PR #1056 about adding new images to the openstack version. To be honest I'm not fully sure what the final resolution there is and what's required to be done to add new images.

I saw there were concerns about the image being set to nil in an old target version in the openstackversion. So I added a check for that. If it's nil, then openstack-operator will set the image to empty string and telemetry-operator will default it with its webhook to the image set here: https://github.com/openstack-k8s-operators/telemetry-operator/blob/main/api/v1beta1/ceilometer_types.go#L44 Once the target version is changed to a newer version, which includes the mysqld_exporter image, then the image gets set by the openstack-operator similarly to all other images.

Did I miss something? Are there some other concerns I should address?

@vyzigold
Copy link
Contributor Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant