Cleanup legacy OLM Subscription & CSVs #1282
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprince The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Got this link from Joe today: https://github.com/operator-framework/kubectl-operator/blob/ddb2132976fa3e0ca5da63915c29c77b9240da70/internal/pkg/action/operator_uninstall.go#L186-L242 which may help us improve this further |
|
Looks ok to me. What are the leftover "operator" resources? |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8792d2b1fecf48c6a9edbb1ba9e8cdfa ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 19m 23s |
dprince
force-pushed
the
csv_cleanup
branch
4 times, most recently
from
f679db0 to
5e2c837
Compare
This cleans up legacy resources installed by OLM dependencies in old releases by searching for specifically named resources. This PR uses the unstructured client so that we don't have to import structs (and dependencies). NOTE: This PR does not yet address the leftover 'operator' resources which persist and seem to get recreated even if removed.
This will allow cleanup of 'operator' objects which own these resources and got created by service operators prior to FR2
The operator resource's have references to: -CSVs -Subscriptions -Installplans -CRDs So the cleanup for operators needs to run after applyCRDs where 'olm.managed' gets removed.
oc get operator |
| Log.Info("Found CSV", "name", csv.GetName()) | ||
| if isServiceOperatorResource(csv.GetName()) { | ||
| err = r.Client.Delete(ctx, &csv) | ||
| if err != nil { |
There was a problem hiding this comment.
Maybe check for "not found" error here in case the CSV was somehow deleted (in which case it can be ignored and we can just continue)? Probably won't happen, but just a thought.
The horizon operator CR has references to an old Role/Binding. This code will cleanup those objects before attempting to delete the operator and requeue. On 2nd attempt the role/binding refs should have time to delete and the final reconcile will complete.
This cleans up legacy resources installed by OLM dependencies in old releases by searching for specifically named resources.
This PR uses the unstructured client so that we don't have to import structs (and dependencies).
NOTE: This PR does not yet address the leftover 'operator' resources which persist and seem to get recreated even if removed.