Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable openstack-baremetal-operator webhooks #1284

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rabi
Copy link
Contributor

@rabi rabi commented Feb 3, 2025

Few of the reasons:

  • All defaulting and validation is not done in the openstack-operator webhooks.
  • There is an option to create OpenStackProvisionServer directly and reuse it for provisioning multiple
    OpenStackDataPlaneNodeSets.

@openshift-ci openshift-ci bot requested review from fao89 and frenzyfriday February 3, 2025 12:55
@openshift-ci openshift-ci bot added the approved label Feb 3, 2025
Copy link
Contributor

openshift-ci bot commented Feb 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprince, rabi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprince
Copy link
Contributor

dprince commented Feb 3, 2025

@rabi looks good. Just a heads up there is a cleanup issue with webhooks I plan to address this week: https://issues.redhat.com/browse/OSPRH-13217

@dprince
Copy link
Contributor

dprince commented Feb 3, 2025

@rabi actually, did you run 'make bindata'? I would expect to see the newly added webhooks get pulled into that directory

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a79768271af44a938da62e123130784e

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 28m 12s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 10m 46s
cifmw-crc-podified-edpm-baremetal FAILURE in 52m 02s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 42m 45s

@openshift-ci openshift-ci bot removed the lgtm label Feb 4, 2025
Copy link
Contributor

openshift-ci bot commented Feb 4, 2025

New changes are detected. LGTM label has been removed.

Few of the reasons:

- All defaulting and validation is done in the openstack-operator
  webhooks.
- There is an option to create OpenStackProvisionServer
  directly and reuse it for provisioning multiple
  OpenStackDataPlaneNodeSets.

Signed-off-by: rabi <[email protected]>
@rabi
Copy link
Contributor Author

rabi commented Feb 4, 2025

@rabi actually, did you run 'make bindata'? I would expect to see the newly added webhooks get pulled into that directory

Now it does I think and I missed some other changes as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants