-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable openstack-baremetal-operator webhooks #1284
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprince, rabi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rabi looks good. Just a heads up there is a cleanup issue with webhooks I plan to address this week: https://issues.redhat.com/browse/OSPRH-13217 |
@rabi actually, did you run 'make bindata'? I would expect to see the newly added webhooks get pulled into that directory |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a79768271af44a938da62e123130784e ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 28m 12s |
New changes are detected. LGTM label has been removed. |
Few of the reasons: - All defaulting and validation is done in the openstack-operator webhooks. - There is an option to create OpenStackProvisionServer directly and reuse it for provisioning multiple OpenStackDataPlaneNodeSets. Signed-off-by: rabi <[email protected]>
Now it does I think and I missed some other changes as well. |
Few of the reasons:
OpenStackDataPlaneNodeSets.