-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webhook cleanup on init resource delete #1286
webhook cleanup on init resource delete #1286
Conversation
This adds a label to webhooks created by the intialization resource "openstack.openstack.org/managed=true" so that upon deletion they can be deleted. Also adds a finalizer on the openstack initialization resource and code in reconcileDelete to cleanup the above labelled webhooks. Jira: OSPRH-13217
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprince The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/cec56a1bcc654d08bd69f4a8e179a139 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 23m 02s |
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/520b8ca9ef5a463189d3865f5235b527 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 47m 18s |
recheck |
/test openstack-operator-build-deploy-kuttl |
1 similar comment
/test openstack-operator-build-deploy-kuttl |
e523d7a
into
openstack-k8s-operators:main
This adds a label to webhooks created by the intialization
resource "openstack.openstack.org/managed=true" so that
upon deletion they can be deleted.
Also adds a finalizer on the openstack initialization resource
and code in reconcileDelete to cleanup the above labelled webhooks.
Ownership is also set on "rbac" related bindata objects
Jira: OSPRH-13217