Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webhook cleanup on init resource delete #1286

Merged

Conversation

dprince
Copy link
Contributor

@dprince dprince commented Feb 3, 2025

This adds a label to webhooks created by the intialization
resource "openstack.openstack.org/managed=true" so that
upon deletion they can be deleted.

Also adds a finalizer on the openstack initialization resource
and code in reconcileDelete to cleanup the above labelled webhooks.

Ownership is also set on "rbac" related bindata objects

Jira: OSPRH-13217

This adds a label to webhooks created by the intialization
resource "openstack.openstack.org/managed=true" so that
upon deletion they can be deleted.

Also adds a finalizer on the openstack initialization resource
and code in reconcileDelete to cleanup the above labelled webhooks.

Jira: OSPRH-13217
@openshift-ci openshift-ci bot requested review from frenzyfriday and rabi February 3, 2025 20:25
Copy link
Contributor

openshift-ci bot commented Feb 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprince

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 3, 2025
@dprince dprince requested a review from abays February 3, 2025 20:26
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/cec56a1bcc654d08bd69f4a8e179a139

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 23m 02s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 11m 45s
cifmw-crc-podified-edpm-baremetal FAILURE in 38m 40s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 31m 06s

@rabi
Copy link
Contributor

rabi commented Feb 4, 2025

recheck

Copy link
Contributor

@rabi rabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 4, 2025
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/520b8ca9ef5a463189d3865f5235b527

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 47m 18s
podified-multinode-edpm-deployment-crc POST_FAILURE in 1h 14m 16s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 12m 07s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 33m 47s

@abays
Copy link
Contributor

abays commented Feb 4, 2025

recheck

@dprince
Copy link
Contributor Author

dprince commented Feb 4, 2025

/test openstack-operator-build-deploy-kuttl

1 similar comment
@abays
Copy link
Contributor

abays commented Feb 4, 2025

/test openstack-operator-build-deploy-kuttl

@openshift-merge-bot openshift-merge-bot bot merged commit e523d7a into openstack-k8s-operators:main Feb 4, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants