Create Ironic and Octavia services routes based on annotations on the svc endpoint #488
Conversation
stuggi
changed the title
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/0a9c53bbcc784de7aed4f6e32ea9a461 ❌ openstack-k8s-operators-content-provider FAILURE in 9m 47s |
| } | ||
|
|
||
| // Ironic Inspector | ||
| if ironic.Status.Conditions.IsTrue(ironicv1.IronicInspectorReadyCondition) { |
There was a problem hiding this comment.
This condition is currently set to True by ironic-operator also when Inspector service is not requested (by setting replicas = 0). Would the remaining code here fail in that case? Or will svcs simply be empty an EnsureRoute would simply not create any resources?
Setting the condition to True when service is not requested in ironic-operator might not be the right thing to do ...
There was a problem hiding this comment.
when there is no service created by the ironic operator which has the IngressCreate annotation [1] (done by the service operator), there won't be a route created.
[1] https://github.com/openstack-k8s-operators/lib-common/blob/main/modules/common/service/types.go#L44
Creates the route for the ironicapi and ironicinspector, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/ironic-operator#334 Jira: OSP-26690
Creates the route for the octaviaapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/octavia-operator#171 Jira: OSP-26690
stuggi
force-pushed
the
handle_ingress_v3_ironic_octavia
branch
from
3cac4ea to
f2a34af
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is a follow up to #457 to also migrate ironic and octavia to have their routes created via the openstack-operator.
Depends-On: openstack-k8s-operators/ironic-operator#334
Depends-On: openstack-k8s-operators/octavia-operator#171