Fix override of rendered files via tarball #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracting/placing default tht files via the script to render the playbooks is intended to allow to override default and rendered tht files. Right now the ordering to copy the files in the final place first copies the tarball and afterwards the default/rendered ones. This prevents from override them via the tarball. This changes the order to extract the tarball last. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2251800
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit b3400ec
into
openstack-k8s-operators:master
10 checks passed
|
/cherry-pick v1.3.x |
|
@stuggi: new pull request created: #955 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracting/placing default tht files via the script to render the playbooks is intended to allow to override default and rendered tht files. Right now the ordering to copy the files in the final place first copies the tarball and afterwards the default/rendered ones. This prevents from override them via the tarball.
This changes the order to extract the tarball last.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2251800