Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[envtest]Cover reconfiguration cases #74

Conversation

gibizer
Copy link
Collaborator

@gibizer gibizer commented Sep 18, 2023

@gibizer gibizer changed the title Envtest reconfiguration [envtest]Cover reconfiguration cases Sep 18, 2023
@gibizer
Copy link
Collaborator Author

gibizer commented Sep 18, 2023

/hold wait for dependencies to land

@gibizer
Copy link
Collaborator Author

gibizer commented Sep 20, 2023

kuttl failure seems relevant, something in the lib-common bump causing wrong endpoint naming:

    logger.go:42: 13:15:50 | placement_scale/2-patch_placement_deploy | Regex check 'http:\/\/placement-internal\..+\.svc.*' failed against oc output: http://://placement-internal.placement-kuttl-tests.svc:8778:http://://placement-public-placement-kuttl-tests.apps.oko-13.oooci.ccitredhat.com:8778

@gibizer
Copy link
Collaborator Author

gibizer commented Sep 20, 2023

kuttl failure seems relevant, something in the lib-common bump causing wrong endpoint naming:

    logger.go:42: 13:15:50 | placement_scale/2-patch_placement_deploy | Regex check 'http:\/\/placement-internal\..+\.svc.*' failed against oc output: http://://placement-internal.placement-kuttl-tests.svc:8778:http://://placement-public-placement-kuttl-tests.apps.oko-13.oooci.ccitredhat.com:8778

adapting to the new lib-common change is more complicated than I anticipated. It is probably better to wait for #61 to land and then rebase this after.

@gibizer
Copy link
Collaborator Author

gibizer commented Sep 21, 2023

kuttl failure seems relevant, something in the lib-common bump causing wrong endpoint naming:

    logger.go:42: 13:15:50 | placement_scale/2-patch_placement_deploy | Regex check 'http:\/\/placement-internal\..+\.svc.*' failed against oc output: http://://placement-internal.placement-kuttl-tests.svc:8778:http://://placement-public-placement-kuttl-tests.apps.oko-13.oooci.ccitredhat.com:8778

adapting to the new lib-common change is more complicated than I anticipated. It is probably better to wait for #61 to land and then rebase this after.

#61 landed and this is rebased so no need to lib-common bump

@gibizer gibizer force-pushed the envtest-reconfiguration branch from cacc537 to 8a23166 Compare September 21, 2023 13:38
@gibizer
Copy link
Collaborator Author

gibizer commented Sep 21, 2023

/unhold
dependencies landed

Copy link
Contributor

@mrkisaolamb mrkisaolamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, mrKisaoLamb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gibizer,mrKisaoLamb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 10eaade into openstack-k8s-operators:main Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants