-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[envtest]Cover reconfiguration cases #74
[envtest]Cover reconfiguration cases #74
Conversation
/hold wait for dependencies to land |
926acd8
to
bf89550
Compare
bf89550
to
f6b7200
Compare
f6b7200
to
513b4b7
Compare
kuttl failure seems relevant, something in the lib-common bump causing wrong endpoint naming:
|
adapting to the new lib-common change is more complicated than I anticipated. It is probably better to wait for #61 to land and then rebase this after. |
513b4b7
to
cacc537
Compare
#61 landed and this is rebased so no need to lib-common bump |
cacc537
to
8a23166
Compare
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gibizer, mrKisaoLamb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Depends-On: openstack-k8s-operators/lib-common#337 (merged)
Depends-On: #63 (merged)
Related: https://issues.redhat.com/browse/OSPRH-108