Skip to content

Commit

Permalink
Merge pull request #231 from cschwede/standardize-finalizer
Browse files Browse the repository at this point in the history
Standardize swift-ring finalizer name
  • Loading branch information
openshift-merge-bot[bot] authored Jun 19, 2024
2 parents f03281e + 530db93 commit 252083b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion controllers/swiftring_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ func (r *SwiftRingReconciler) reconcileDelete(ctx context.Context, instance *swi
if err == nil {
// This finalizer is directly set when creating the ConfigMap using
// curl within the Job
if controllerutil.RemoveFinalizer(ringConfigMap, "swift-ring/finalizer") {
if controllerutil.RemoveFinalizer(ringConfigMap, "openstack.org/swiftring") {
err = r.Update(ctx, ringConfigMap)
if err != nil && !apierrors.IsNotFound(err) {
return ctrl.Result{}, err
Expand Down
2 changes: 1 addition & 1 deletion templates/swiftring/bin/swift-ring-tool
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ function push() {
'${VERSION}'
"name":"'${CM_NAME}'",
"namespace":"'${NAMESPACE}'",
"finalizers": ["swift-ring/finalizer"],
"finalizers": ["openstack.org/swiftring"],
"ownerReferences": [
{
"apiVersion": "'${OWNER_APIVERSION}'",
Expand Down

0 comments on commit 252083b

Please sign in to comment.