[tempest] Remove unnecessary sudo calls

openstack-k8s-operators · Aug 30, 2024 · e551777 · e551777
1 parent a7ffdf8
commit e551777
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/container-images/tcib/base/os/tempest/run_tempest.sh b/container-images/tcib/base/os/tempest/run_tempest.sh
@@ -228,7 +228,7 @@ function upload_extra_images {
             image_create_params=()
 
             [[ ! -f "${TEMPEST_EXTRA_IMAGES_NAME[image_index]}" ]] && \
-                sudo curl -o "${TEMPEST_EXTRA_IMAGES_NAME[image_index]}" "${TEMPEST_EXTRA_IMAGES_URL[image_index]}"
+                curl -o "${HOMEDIR}/${TEMPEST_EXTRA_IMAGES_NAME[image_index]}" "${TEMPEST_EXTRA_IMAGES_URL[image_index]}"
 
             [[ ${TEMPEST_EXTRA_IMAGES_DISK_FORMAT[image_index]} != "-" ]] && \
                 image_create_params+=(--disk-format ${TEMPEST_EXTRA_IMAGES_DISK_FORMAT[image_index]})
@@ -240,7 +240,7 @@ function upload_extra_images {
                 image_create_params+=(--id ${TEMPEST_EXTRA_IMAGES_ID[image_index]})
 
             [[ ${TEMPEST_EXTRA_IMAGES_NAME[image_index]} != "-" ]] && \
-                image_create_params+=(--file ${TEMPEST_EXTRA_IMAGES_NAME[image_index]})
+                image_create_params+=(--file "${HOMEDIR}/${TEMPEST_EXTRA_IMAGES_NAME[image_index]}")
 
             [[ ${TEMPEST_EXTRA_IMAGES_CONTAINER_FORMAT[image_index]} != "-" ]] && \
                 image_create_params+=(--container-format ${TEMPEST_EXTRA_IMAGES_CONTAINER_FORMAT[image_index]})
@@ -406,9 +406,9 @@ fi
 if [ -f ${HOMEDIR}/id_ecdsa ]; then
     mkdir -p ${HOMEDIR}/.ssh
     cp ${HOMEDIR}/id_ecdsa ${HOMEDIR}/.ssh/id_ecdsa
-    sudo chmod 700 ${HOMEDIR}/.ssh
-    sudo chmod 600 ${HOMEDIR}/.ssh/id_ecdsa
-    sudo chown -R tempest:tempest ${HOMEDIR}/.ssh
+    chmod 700 ${HOMEDIR}/.ssh
+    chmod 600 ${HOMEDIR}/.ssh/id_ecdsa
+    chown -R tempest:tempest ${HOMEDIR}/.ssh
 fi
 
 if [ -z $TEMPEST_EXTERNAL_PLUGIN_GIT_URL ]; then

diff --git a/container-images/tcib/base/os/tempest/tempest_sudoers b/container-images/tcib/base/os/tempest/tempest_sudoers
@@ -1 +1 @@
-tempest        ALL=(ALL)       NOPASSWD: ALL
+tempest ALL=(ALL) NOPASSWD: /usr/bin/dnf
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		tempest ALL=(ALL) NOPASSWD: ALL
		tempest ALL=(ALL) NOPASSWD: /usr/bin/dnf