Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[placement] remove example httpd /etc/httpd/conf.d/00-placement-api.conf #111

Conversation

stuggi
Copy link
Contributor

@stuggi stuggi commented Dec 12, 2023

The openstack-placement-api rpm provides an example placement httpd config at /etc/httpd/conf.d/00-placement-api.conf when enable httpd to read configs from /etc/httpd/conf.d to fail.

$ podman run -it -u root --rm quay.io/podified-antelope-centos9/openstack-placement-api:current-podified sh sh-5.1# rpm -qf /etc/httpd/conf.d/
00-placement-api.conf  autoindex.conf         README                 ssl.conf               userdir.conf           welcome.conf
sh-5.1# rpm -qf /etc/httpd/conf.d/00-placement-api.conf
openstack-placement-api-9.0.1-0.20230331173037.b3652fe.el9.noarch

This deletes this default config as the operator will provide a httpd config for placement.

The openstack-placement-api rpm provides an example placement httpd
config at /etc/httpd/conf.d/00-placement-api.conf when enable httpd
to read configs from /etc/httpd/conf.d to fail.

$ podman run -it -u root --rm quay.io/podified-antelope-centos9/openstack-placement-api:current-podified sh
sh-5.1# rpm -qf /etc/httpd/conf.d/
00-placement-api.conf  autoindex.conf         README                 ssl.conf               userdir.conf           welcome.conf
sh-5.1# rpm -qf /etc/httpd/conf.d/00-placement-api.conf
openstack-placement-api-9.0.1-0.20230331173037.b3652fe.el9.noarch

This deletes this default config as the operator will provide a
httpd config for placement.
@openshift-ci openshift-ci bot requested review from rlandy and son-vyas December 12, 2023 13:37
@stuggi
Copy link
Contributor Author

stuggi commented Dec 12, 2023

when enable httpd to read configs from conf.d, fails right now with:

oc logs placement-b586c5c65-ctdkl
Defaulted container "placement-api" out of: placement-api, init (init)
+ sudo -E kolla_set_configs                                                 
sudo: unable to send audit message: Operation not permitted             
INFO:__main__:Loading config file at /var/lib/kolla/config_files/config.json
INFO:__main__:Validating config file                                      
INFO:__main__:Kolla config strategy set to: COPY_ALWAYS            
INFO:__main__:Copying service configuration files                  
INFO:__main__:Deleting /etc/placement/placement.conf                          
INFO:__main__:Copying /var/lib/config-data/merged/placement.conf to /etc/placement/placement.conf
INFO:__main__:Setting permission for /etc/placement/placement.conf        
INFO:__main__:Copying /var/lib/config-data/merged/custom.conf to /etc/placement/placement.conf.d/custom.conf
INFO:__main__:Setting permission for /etc/placement/placement.conf.d/custom.conf
INFO:__main__:Deleting /etc/httpd/conf/httpd.conf                  
INFO:__main__:Copying /var/lib/config-data/merged/httpd.conf to /etc/httpd/conf/httpd.conf
INFO:__main__:Setting permission for /etc/httpd/conf/httpd.conf             
INFO:__main__:Deleting /etc/httpd/conf.d/ssl.conf                  
INFO:__main__:Copying /var/lib/config-data/merged/ssl.conf to /etc/httpd/conf.d/ssl.conf
INFO:__main__:Setting permission for /etc/httpd/conf.d/ssl.conf            
INFO:__main__:Copying /var/lib/config-data/merged/logging.conf to /etc/placement/logging.conf
INFO:__main__:Setting permission for /etc/placement/logging.conf   
INFO:__main__:Writing out command to execute                       
INFO:__main__:Setting permission for /var/log/placement            
INFO:__main__:Setting permission for /etc/httpd/run/                  
INFO:__main__:Setting permission for /etc/httpd/run/htcacheclean   
++ cat /run_command                                                
+ CMD='/usr/sbin/httpd -DFOREGROUND'                               
+ ARGS=                                                            
+ sudo kolla_copy_cacerts                                          
sudo: unable to send audit message: Operation not permitted           
+ [[ ! -n '' ]]                                                               
+ . kolla_extend_start                                                    
+ echo 'Running command: '\''/usr/sbin/httpd -DFOREGROUND'\'''     
Running command: '/usr/sbin/httpd -DFOREGROUND'                    
+ umask 0022                                                                
+ exec /usr/sbin/httpd -DFOREGROUND                                           
httpd: Syntax error on line 16 of /etc/httpd/conf/httpd.conf: Could not open configuration file /etc/httpd/conf.d/00-placement-api.conf: Permission denied

$ podman run -it -u root --rm quay.io/podified-antelope-centos9/openstack-placement-api:current-podified sh
sh-5.1# ls -la /etc/httpd/conf.d/00-placement-api.conf             
-rw-r-----. 1 root root 671 Mar 16  2023 /etc/httpd/conf.d/00-placement-api.conf

@stuggi stuggi requested a review from gibizer December 12, 2023 13:38
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/9551549c224f4cc984bd8c09d8940eeb

✔️ tcib-build-containers SUCCESS in 59m 50s
tcib-crc-podified-edpm-baremetal RETRY_LIMIT in 2m 23s
tcib-podified-multinode-edpm-deployment-crc RETRY_LIMIT in 14m 15s

@stuggi
Copy link
Contributor Author

stuggi commented Dec 12, 2023

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/61eb2b639fe445f5aa88a2b6c0794da3

✔️ tcib-build-containers SUCCESS in 46m 04s
tcib-crc-podified-edpm-baremetal RETRY_LIMIT in 3s
tcib-podified-multinode-edpm-deployment-crc RETRY_LIMIT in 3s

@gibizer
Copy link
Contributor

gibizer commented Dec 13, 2023

recheck

@gibizer
Copy link
Contributor

gibizer commented Dec 13, 2023

This is needed for the TLSe work as there we will put the ssl.conf into the conf.d. Eventually we should either fix or remove the borken sample file from the RPM.

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/a3f77600f09e4617a0bba50274ac75a1

✔️ tcib-build-containers SUCCESS in 1h 56m 21s
tcib-crc-podified-edpm-baremetal FAILURE in 50m 25s
✔️ tcib-podified-multinode-edpm-deployment-crc SUCCESS in 1h 06m 55s

@stuggi
Copy link
Contributor Author

stuggi commented Dec 14, 2023

recheck

@stuggi
Copy link
Contributor Author

stuggi commented Dec 14, 2023

@rlandy @raukadah could you approve this?

Copy link
Contributor

openshift-ci bot commented Dec 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, raukadah, SeanMooney, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7bf4dba into openstack-k8s-operators:main Dec 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants