Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove temporary skip of tempest-all package #112

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Conversation

kopecmartin
Copy link
Contributor

openstack-tempest-all package was temporarily replaced with only
openstack-tempest one because whitebox-neutron-tempest plugin
wasn't available on rhel.
These patches make sure that the plugin is included in the
openstack-tempest-all package only in upstream:
https://review.rdoproject.org/r/q/I93f6cee77927dfadd15c8093b49b1ed1f3e04cdc
Thus it's safe to get the things back as they were.

openstack-tempest-all package was temporarily replaced with only
openstack-tempest one because whitebox-neutron-tempest plugin
wasn't available on rhel.
These patches make sure that the plugin is included in the
openstack-tempest-all package only in upstream:
https://review.rdoproject.org/r/q/I93f6cee77927dfadd15c8093b49b1ed1f3e04cdc
Thus it's safe to get the things back as they were.
@openshift-ci openshift-ci bot requested review from rabi and viroel December 12, 2023 15:00
@viroel
Copy link
Contributor

viroel commented Dec 12, 2023

/approve

thanks, this is a must, we need plugins installed to continue with other tasks.

@gouthampacha
Copy link

+1

We'll need this to run tests from tempest plugins in the jobs... Thanks @kopecmartin

Copy link
Contributor

@arxcruz arxcruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve but if it start to fails, I will revert again :)

Copy link
Contributor

openshift-ci bot commented Dec 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arxcruz, kopecmartin, viroel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@viroel
Copy link
Contributor

viroel commented Dec 12, 2023

/approve but if it start to fails, I will revert again :)

It is worst to build image called tempest-all without openstack-tempest-all package, it causes confusion for those that are using it - it is better to stop building it or letting it failure until the correct fix is landed.

@karelyatin
Copy link
Contributor

/lgtm

@son-vyas
Copy link
Contributor

/lgtm. Thanks @kopecmartin we need this fix for manila tempest tests.

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/2945348db3e64e5dbefb0706a4581e49

✔️ tcib-build-containers SUCCESS in 46m 20s
tcib-crc-podified-edpm-baremetal RETRY_LIMIT in 3s
tcib-podified-multinode-edpm-deployment-crc RETRY_LIMIT in 3s

@son-vyas
Copy link
Contributor

/retest

@son-vyas
Copy link
Contributor

recheck

@viroel
Copy link
Contributor

viroel commented Dec 12, 2023

"Perform container registry login(s) with podman failed running on host controller"
Probably due to "quay.rdoproject.org update" process

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/6a3d103093184cef9f8f60965c4c6640

✔️ tcib-build-containers SUCCESS in 1h 58m 52s
✔️ tcib-crc-podified-edpm-baremetal SUCCESS in 1h 15m 13s
tcib-podified-multinode-edpm-deployment-crc RETRY_LIMIT in 3s

@kopecmartin
Copy link
Contributor Author

recheck

@openshift-merge-bot openshift-merge-bot bot merged commit e3e1923 into main Dec 13, 2023
2 checks passed
@kopecmartin kopecmartin deleted the tempest-all2 branch December 14, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants