Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop etcd from tcib #191

Merged

Conversation

raukadah
Copy link
Collaborator

@raukadah raukadah commented Jul 31, 2024

Signed-off-by: Chandan Kumar <[email protected]>
Copy link
Contributor

openshift-ci bot commented Jul 31, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@raukadah raukadah marked this pull request as ready for review August 5, 2024 01:15
@openshift-ci openshift-ci bot requested review from rlandy and son-vyas August 5, 2024 01:16
@lhh
Copy link

lhh commented Aug 15, 2024

This is fine. My understanding is that there is no operator for this container at the moment; if we need one later, we can put it back.

Copy link
Contributor

openshift-ci bot commented Aug 15, 2024

@lhh: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Collaborator

@rlandy rlandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rlandy
Copy link
Collaborator

rlandy commented Aug 16, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Aug 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhh, raukadah, rlandy, viroel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [raukadah,rlandy,viroel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e87f25a into openstack-k8s-operators:main Aug 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants