[Tempest] Remove cirros image from logs #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up until now we were collecting cirros image that is downloaded during the discover-tempest-config phase into the logs folder. The cirros image is not needed artifact and in some edge cases it might happen that the cirros file is too big for it to be stored in the external PV. This patch removes the cirros image before the logs are collected.
|
lgtm |
|
just a small nit, like have we tested this change like removing the image not breaking any other stuffs? like just a sanity check would be a good thing to have |
marios
approved these changes
Aug 12, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: kopecmartin, lpiwowar, marios The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit d2bd527
into
openstack-k8s-operators:main
5 checks passed
rdiazcam
added a commit
to rdiazcam/tcib
that referenced
this pull request
Oct 17, 2024
In addtion to deleting the files with img extension [0] from the logs folder, delete also qcow2 files. [0] openstack-k8s-operators#197
rdiazcam
added a commit
to rdiazcam/tcib
that referenced
this pull request
Oct 17, 2024
In addtion to deleting the files with img extension [0] from the logs folder, delete also qcow2 files. [0] openstack-k8s-operators#197
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/tcib
that referenced
this pull request
Nov 20, 2024
In addtion to deleting the files with img extension [0] from the logs folder, delete also qcow2 files. [0] openstack-k8s-operators#197
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now we were collecting cirros image that is downloaded during the discover-tempest-config phase into the logs folder. The cirros image is not needed artifact and in some edge cases it might happen that the cirros file is too big for it to be stored in the external PV.
This patch removes the cirros image before the logs are collected.