-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tempest] Modify IMAGES_TIMEOUT for individual images #199
[Tempest] Modify IMAGES_TIMEOUT for individual images #199
Conversation
This PR first requires confirmation from @lkuchlan. |
Thanks Lukas! LGTM! |
@lkuchlan: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@lkuchlan thanks for the review. Keeping this as a draft until we merge this -> openstack-k8s-operators/test-operator#166 |
aee7c0d
to
5b0fac9
Compare
This patch allows to modify IMAGES_CREATION_TIMEOUT for individual images. This better fits the interface of the extraImges parameter in the Tempest CR [1]. [1] openstack-k8s-operators/test-operator#166
5b0fac9
to
101a6ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: kopecmartin, lkuchlan, lpiwowar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
77e60ff
into
openstack-k8s-operators:main
/cherrypick 18.0.0-proposed |
@lpiwowar: #199 failed to apply on top of branch "18.0.0-proposed":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This patch allows to modify IMAGES_CREATION_TIMEOUT for individual images. This better fits the interface of the extraImges parameter in the Tempest CR [1].
[1] openstack-k8s-operators/test-operator#166