Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tempest] Modify IMAGES_TIMEOUT for individual images #199

Merged

Conversation

lpiwowar
Copy link
Contributor

@lpiwowar lpiwowar commented Aug 16, 2024

This patch allows to modify IMAGES_CREATION_TIMEOUT for individual images. This better fits the interface of the extraImges parameter in the Tempest CR [1].

[1] openstack-k8s-operators/test-operator#166

@openshift-ci openshift-ci bot requested review from rabi and viroel August 16, 2024 09:48
@lpiwowar lpiwowar marked this pull request as draft August 16, 2024 09:48
@lpiwowar
Copy link
Contributor Author

This PR first requires confirmation from @lkuchlan.

@lkuchlan
Copy link
Contributor

lkuchlan commented Aug 17, 2024

Thanks Lukas! LGTM!

Copy link
Contributor

openshift-ci bot commented Aug 17, 2024

@lkuchlan: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lpiwowar
Copy link
Contributor Author

@lkuchlan thanks for the review. Keeping this as a draft until we merge this -> openstack-k8s-operators/test-operator#166

@lpiwowar lpiwowar marked this pull request as ready for review August 20, 2024 11:50
@openshift-ci openshift-ci bot requested a review from son-vyas August 20, 2024 11:50
@lpiwowar lpiwowar requested review from kopecmartin and removed request for son-vyas August 20, 2024 11:50
@lpiwowar lpiwowar marked this pull request as draft August 21, 2024 07:27
@lpiwowar lpiwowar marked this pull request as ready for review August 27, 2024 09:20
@openshift-ci openshift-ci bot requested review from rlandy and son-vyas August 27, 2024 09:20
This patch allows to modify IMAGES_CREATION_TIMEOUT for individual
images. This better fits the interface of the extraImges parameter in
the Tempest CR [1].

[1] openstack-k8s-operators/test-operator#166
Copy link
Contributor

@kopecmartin kopecmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

openshift-ci bot commented Aug 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: kopecmartin, lkuchlan, lpiwowar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 77e60ff into openstack-k8s-operators:main Aug 28, 2024
5 checks passed
@lpiwowar lpiwowar deleted the fix/image-timeout branch August 28, 2024 14:11
@lpiwowar
Copy link
Contributor Author

lpiwowar commented Sep 4, 2024

/cherrypick 18.0.0-proposed

@openshift-cherrypick-robot

@lpiwowar: #199 failed to apply on top of branch "18.0.0-proposed":

Applying: Modify IMAGES_TIMEOUT for individual images
Using index info to reconstruct a base tree...
M	container-images/tcib/base/os/tempest/run_tempest.sh
Falling back to patching base and 3-way merge...
Auto-merging container-images/tcib/base/os/tempest/run_tempest.sh
CONFLICT (content): Merge conflict in container-images/tcib/base/os/tempest/run_tempest.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Modify IMAGES_TIMEOUT for individual images
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick 18.0.0-proposed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants