Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing defaults in ansible-tests #207

Merged

Conversation

kopecmartin
Copy link
Contributor

The run_ansible.sh was missing default values for couple of parameters potentially causing "unbound variable" error.

@openshift-ci openshift-ci bot requested review from raukadah and son-vyas September 5, 2024 14:25
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8e4e0ad3af1543acb7ba6df80802845d

✔️ openstack-meta-content-provider SUCCESS in 2h 50m 44s
✔️ tcib-crc-podified-edpm-baremetal SUCCESS in 1h 25m 37s
tcib-podified-multinode-edpm-deployment-crc FAILURE in 1h 02m 13s

@kopecmartin
Copy link
Contributor Author

recheck

The run_ansible.sh was missing default values for couple of
parameters potentially causing "unbound variable" error.
Copy link
Contributor

@lpiwowar lpiwowar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

Copy link
Contributor

openshift-ci bot commented Sep 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: kopecmartin, lpiwowar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit bd5beba into openstack-k8s-operators:main Sep 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants