[tempest] Handle quotes in TEMPESTCONF_OVERRIDES #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use 'eval' to expand the TEMPESTCONF_OVERRIDES variable prior to using it to run discover-tempest-config. This prevents embedded quotes within the variable from being mangled. Without the 'eval' embedded quoted strings like "Some String" get mangled into '"Some' 'String"' on the resulting command line. Jira: OSPRH-10092
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: ASBishop, kopecmartin, lpiwowar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 4e2af59
into
openstack-k8s-operators:main
5 checks passed
ASBishop
added a commit
to ASBishop/tcib
that referenced
this pull request
Sep 18, 2024
Fix a regression introduced in PR openstack-k8s-operators#210 in which strings with special bash characters need to be escaped: cubswin:) has to be cubswin:\). The need to escape some characters breaks existing CI jobs. This patch fixes the regression so it's not necessary to escape special characters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use 'eval' to expand the TEMPESTCONF_OVERRIDES variable prior to using it to run discover-tempest-config. This prevents embedded quotes within the variable from being mangled.
Without the 'eval' embedded quoted strings like "Some String" get mangled into '"Some' 'String"' on the resulting command line.
Jira: OSPRH-10092