Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define tempest-all image #98

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Define tempest-all image #98

merged 1 commit into from
Dec 1, 2023

Conversation

kopecmartin
Copy link
Contributor

@kopecmartin kopecmartin commented Nov 15, 2023 •
edited by raukadah
Loading

Tempest image should contain only tempest while tempest-all image
should contain tempest with all relevant plugins.

Depends-On: #97

@openshift-ci openshift-ci bot requested review from raukadah and son-vyas November 15, 2023 08:12
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/a7592c85e9144f24af023b73e7be3c87

✔️ tcib-build-containers SUCCESS in 1h 41m 00s
❌ tcib-crc-podified-edpm-baremetal FAILURE in 1h 00m 20s
❌ tcib-podified-multinode-edpm-deployment-crc FAILURE in 1h 03m 17s

@kopecmartin
Define tempest-all image
7d75e83 
Tempest image should contain only tempest while tempest-all image
should contain tempest with all relevant plugins.
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/b6a62d2b90864713a625ba1ad3ddc7b4

✔️ tcib-build-containers SUCCESS in 1h 46m 19s
❌ tcib-crc-podified-edpm-baremetal FAILURE in 1h 05m 38s
❌ tcib-podified-multinode-edpm-deployment-crc FAILURE in 1h 07m 26s

@kopecmartin
Copy link
Contributor Author

Firstly, no idea why I can't see the tempest-all container build, I see tempest and tempest-extra, not the new one - tempest-all :/
Secondly, maybe we don't need tempest-all - I'd like to compare the size of the image with all the plugins with the one where only tempest is and if the difference isn't significant we can have just one image with all the plugins and not distinguish between tempest and tempest-all

@raukadah
Copy link
Collaborator

recheck

@raukadah
Copy link
Collaborator

Firstly, no idea why I can't see the tempest-all container build, I see tempest and tempest-extra, not the new one - tempest-all :/ Secondly, maybe we don't need tempest-all - I'd like to compare the size of the image with all the plugins with the one where only tempest is and if the difference isn't significant we can have just one image with all the plugins and not distinguish between tempest and tempest-all

@kopecmartin I have added the depends-on in this pr, now tempest-all image will be built soon.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

This change depends on a change that failed to merge.

Change #97 is needed.

@raukadah
Copy link
Collaborator

recheck

@kopecmartin
Copy link
Contributor Author

Firstly, no idea why I can't see the tempest-all container build, I see tempest and tempest-extra, not the new one - tempest-all :/ Secondly, maybe we don't need tempest-all - I'd like to compare the size of the image with all the plugins with the one where only tempest is and if the difference isn't significant we can have just one image with all the plugins and not distinguish between tempest and tempest-all

@kopecmartin I have added the depends-on in this pr, now tempest-all image will be built soon.

oh, right, I forgot about that, thanks Chandan!

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/a3f102012a244bf5932aac1a63049e40

✔️ tcib-build-containers SUCCESS in 1h 37m 59s
❌ tcib-crc-podified-edpm-baremetal FAILURE in 33m 48s
✔️ tcib-podified-multinode-edpm-deployment-crc SUCCESS in 1h 00m 25s

@raukadah
Copy link
Collaborator

@kopecmartin https://logserver.rdoproject.org/98/98/7d75e833dc34ca4d83f7f758be3091cae0150256/github-check/tcib-build-containers/103afd0/ci-framework-data/logs/containers-built.log

38.102.83.194:5001/podified-antelope-centos9/openstack-tempest-all                 7875d401b14a7e53d94789026df40798  d2c77d5a99bf  54 seconds ago      1.07 GB
38.102.83.194:5001/podified-antelope-centos9/openstack-tempest-extras              7875d401b14a7e53d94789026df40798  bad37edde185  About a minute ago  595 MB
38.102.83.194:5001/podified-antelope-centos9/openstack-tempest                     7875d401b14a7e53d94789026df40798  406f5f52dd52  14 minutes ago      533 MB

@kopecmartin
Copy link
Contributor Author

@kopecmartin https://logserver.rdoproject.org/98/98/7d75e833dc34ca4d83f7f758be3091cae0150256/github-check/tcib-build-containers/103afd0/ci-framework-data/logs/containers-built.log

38.102.83.194:5001/podified-antelope-centos9/openstack-tempest-all                 7875d401b14a7e53d94789026df40798  d2c77d5a99bf  54 seconds ago      1.07 GB
38.102.83.194:5001/podified-antelope-centos9/openstack-tempest-extras              7875d401b14a7e53d94789026df40798  bad37edde185  About a minute ago  595 MB
38.102.83.194:5001/podified-antelope-centos9/openstack-tempest                     7875d401b14a7e53d94789026df40798  406f5f52dd52  14 minutes ago      533 MB

amazing, now, I am open for feedback and thoughts on this - tempest without plugins has half the size of the one with plugins, considering our upstream/downstream pipeline, is it worth it to save 500MB per one image download?

@kopecmartin
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/5464058dec314cd08bd5957745dbed06

❌ tcib-build-containers TIMED_OUT in 59m 17s
⚠️ tcib-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job tcib-build-containers
⚠️ tcib-podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job tcib-build-containers

@kopecmartin
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/4fdecf815c9040bea75c7f6bbd744f5b

✔️ tcib-build-containers SUCCESS in 1h 46m 48s
✔️ tcib-crc-podified-edpm-baremetal SUCCESS in 1h 05m 53s
❌ tcib-podified-multinode-edpm-deployment-crc RETRY_LIMIT in 17m 22s

@kopecmartin
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/d4b1e338661b4972badbb1ce413aac89

✔️ tcib-build-containers SUCCESS in 2h 00m 24s
❌ tcib-crc-podified-edpm-baremetal FAILURE in 1h 18m 52s
✔️ tcib-podified-multinode-edpm-deployment-crc SUCCESS in 1h 11m 39s

@kopecmartin
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/7efd554e0c7346e0a3ceb538c4abdaf4

✔️ tcib-build-containers SUCCESS in 1h 54m 07s
❌ tcib-crc-podified-edpm-baremetal RETRY_LIMIT in 5s
✔️ tcib-podified-multinode-edpm-deployment-crc SUCCESS in 1h 09m 17s

@kopecmartin
Copy link
Contributor Author

recheck

marios
marios approved these changes Dec 1, 2023
View reviewed changes
Copy link

@marios marios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 1, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kopecmartin, marios, raukadah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 1, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 3953d8f into main Dec 1, 2023
2 checks passed
@kopecmartin kopecmartin deleted the tempest-all branch December 14, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raukadah raukadah raukadah approved these changes

@marios marios marios approved these changes

@son-vyas son-vyas Awaiting requested review from son-vyas

Assignees

@marios marios

@raukadah raukadah

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kopecmartin @raukadah @marios