Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pydantic error when note missing on link in jsonb #36

Merged
merged 1 commit into from
May 14, 2024

Conversation

jessemortenson
Copy link
Contributor

We have a lot of data that does not have a note for each link. Also many EventMedia rows are missing offset.

Currently requests for VA events are returning 500 due to this error:

10 validation errors for Event
agenda -> 0 -> media -> 0 -> offset
  none is not an allowed value (type=type_error.none.not_allowed)
agenda -> 0 -> media -> 0 -> links -> 0 -> note
  field required (type=value_error.missing)
agenda -> 0 -> media -> 1 -> offset
  none is not an allowed value (type=type_error.none.not_allowed)
agenda -> 0 -> media -> 1 -> links -> 0 -> note
  field required (type=value_error.missing)
agenda -> 0 -> media -> 2 -> offset
  none is not an allowed value (type=type_error.none.not_allowed)
agenda -> 0 -> media -> 2 -> links -> 0 -> note
  field required (type=value_error.missing)
agenda -> 0 -> media -> 3 -> offset
  none is not an allowed value (type=type_error.none.not_allowed)
agenda -> 0 -> media -> 3 -> links -> 0 -> note
  field required (type=value_error.missing)
agenda -> 0 -> media -> 4 -> offset
  none is not an allowed value (type=type_error.none.not_allowed)
agenda -> 0 -> media -> 4 -> links -> 0 -> note
  field required (type=value_error.missing)

We have a lot of data that does not have a note for each link. Also many EventMedia rows are missing offset.
@jessemortenson jessemortenson merged commit ca1de8d into main May 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant