Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sub entity ids returns #38

Merged
merged 1 commit into from
Jan 8, 2025
Merged

sub entity ids returns #38

merged 1 commit into from
Jan 8, 2025

Conversation

amzker
Copy link
Contributor

@amzker amzker commented Dec 20, 2024

  • added ids for actions , documents/versions , sponsorships , votepeople to be returned from api.
  • main reason is i am using openstates api (/bills) to fetch updated bills and then i am checking ids in my database (my db is filled via those bulk csvs and then i am continuing upsert using /bills) before pushing new dataset that was what updated ( ie: ids which are not found in my db but is in updated local json are updates ) , there for ids for sub entity were required.

@jessemortenson jessemortenson merged commit fe18cf4 into openstates:main Jan 8, 2025
1 check failed
@jessemortenson
Copy link
Contributor

Sorry for the delay in reviewing! Just been a really busy time of year. Lot of long days getting new session data in.

I do want to note that sub entity IDs are not guaranteed to have durability. I believe there are some cases where old subentities might get blown away by new incoming ones. If we have a data problem where some bad data gets in, then we reprocess data, "bad" actions or sponsors or votes etc. might get blown away and replaced.

@amzker
Copy link
Contributor Author

amzker commented Jan 8, 2025

Thanks for the update, i will keep note of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants