Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update progress bar wording #69

Merged
merged 1 commit into from
May 1, 2024
Merged

update progress bar wording #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/ProgressBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ export const ProgressBarItem = <S extends {variant: ProgressBarItemVariant}>({in
isActive={isActive}
onClick={() => goToStep(index, step)}
aria-current={isActive ? 'location' : 'false'}
aria-label={step.variant === 'isStatus' ? 'Assignment status' : `Step ${index + 1}` }
aria-label={step.variant === 'isStatus' ? 'Assignment status' : `Question ${index + 1}` }
>
{step.variant === 'isStatus' ? <FlagIcon /> : index + 1}
</StyledItem>
Expand Down
36 changes: 18 additions & 18 deletions src/components/__snapshots__/ProgressBar.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ exports[`ProgressBar matches snapshot 1`] = `
>
<button
aria-current="false"
aria-label="Step 1"
aria-label="Question 1"
className="sc-dkzDqf KrxmS"
onClick={[Function]}
>
Expand Down Expand Up @@ -42,7 +42,7 @@ exports[`ProgressBar matches snapshot 1`] = `
>
<button
aria-current="false"
aria-label="Step 2"
aria-label="Question 2"
className="sc-dkzDqf gKblal"
onClick={[Function]}
>
Expand Down Expand Up @@ -74,7 +74,7 @@ exports[`ProgressBar matches snapshot 1`] = `
>
<button
aria-current="location"
aria-label="Step 3"
aria-label="Question 3"
className="sc-dkzDqf hmFFbY"
onClick={[Function]}
>
Expand Down Expand Up @@ -106,7 +106,7 @@ exports[`ProgressBar matches snapshot 1`] = `
>
<button
aria-current="false"
aria-label="Step 4"
aria-label="Question 4"
className="sc-dkzDqf iyRspZ"
onClick={[Function]}
>
Expand All @@ -118,7 +118,7 @@ exports[`ProgressBar matches snapshot 1`] = `
>
<button
aria-current="false"
aria-label="Step 5"
aria-label="Question 5"
className="sc-dkzDqf iyRspZ"
onClick={[Function]}
>
Expand All @@ -130,7 +130,7 @@ exports[`ProgressBar matches snapshot 1`] = `
>
<button
aria-current="false"
aria-label="Step 6"
aria-label="Question 6"
className="sc-dkzDqf iyRspZ"
onClick={[Function]}
>
Expand Down Expand Up @@ -173,7 +173,7 @@ exports[`ProgressBar matches snapshot when active step is incomplete 1`] = `
>
<button
aria-current="false"
aria-label="Step 1"
aria-label="Question 1"
className="sc-dkzDqf KrxmS"
onClick={[Function]}
>
Expand Down Expand Up @@ -205,7 +205,7 @@ exports[`ProgressBar matches snapshot when active step is incomplete 1`] = `
>
<button
aria-current="false"
aria-label="Step 2"
aria-label="Question 2"
className="sc-dkzDqf gKblal"
onClick={[Function]}
>
Expand Down Expand Up @@ -237,7 +237,7 @@ exports[`ProgressBar matches snapshot when active step is incomplete 1`] = `
>
<button
aria-current="false"
aria-label="Step 3"
aria-label="Question 3"
className="sc-dkzDqf KrxmS"
onClick={[Function]}
>
Expand Down Expand Up @@ -269,7 +269,7 @@ exports[`ProgressBar matches snapshot when active step is incomplete 1`] = `
>
<button
aria-current="location"
aria-label="Step 4"
aria-label="Question 4"
className="sc-dkzDqf ejGnvX"
onClick={[Function]}
>
Expand All @@ -281,7 +281,7 @@ exports[`ProgressBar matches snapshot when active step is incomplete 1`] = `
>
<button
aria-current="false"
aria-label="Step 5"
aria-label="Question 5"
className="sc-dkzDqf iyRspZ"
onClick={[Function]}
>
Expand All @@ -293,7 +293,7 @@ exports[`ProgressBar matches snapshot when active step is incomplete 1`] = `
>
<button
aria-current="false"
aria-label="Step 6"
aria-label="Question 6"
className="sc-dkzDqf iyRspZ"
onClick={[Function]}
>
Expand Down Expand Up @@ -336,7 +336,7 @@ exports[`ProgressBar matches snapshot when status step is active 1`] = `
>
<button
aria-current="false"
aria-label="Step 1"
aria-label="Question 1"
className="sc-dkzDqf KrxmS"
onClick={[Function]}
>
Expand Down Expand Up @@ -368,7 +368,7 @@ exports[`ProgressBar matches snapshot when status step is active 1`] = `
>
<button
aria-current="false"
aria-label="Step 2"
aria-label="Question 2"
className="sc-dkzDqf gKblal"
onClick={[Function]}
>
Expand Down Expand Up @@ -400,7 +400,7 @@ exports[`ProgressBar matches snapshot when status step is active 1`] = `
>
<button
aria-current="false"
aria-label="Step 3"
aria-label="Question 3"
className="sc-dkzDqf KrxmS"
onClick={[Function]}
>
Expand Down Expand Up @@ -432,7 +432,7 @@ exports[`ProgressBar matches snapshot when status step is active 1`] = `
>
<button
aria-current="false"
aria-label="Step 4"
aria-label="Question 4"
className="sc-dkzDqf iyRspZ"
onClick={[Function]}
>
Expand All @@ -444,7 +444,7 @@ exports[`ProgressBar matches snapshot when status step is active 1`] = `
>
<button
aria-current="false"
aria-label="Step 5"
aria-label="Question 5"
className="sc-dkzDqf iyRspZ"
onClick={[Function]}
>
Expand All @@ -456,7 +456,7 @@ exports[`ProgressBar matches snapshot when status step is active 1`] = `
>
<button
aria-current="false"
aria-label="Step 6"
aria-label="Question 6"
className="sc-dkzDqf iyRspZ"
onClick={[Function]}
>
Expand Down
Loading