Save and continue when there is no feedback #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why do it this way? `onAnswerSave` is non-blocking and non-awaitable. Consequently, calling `onAnswerSave` in the onClick of the submit button does not work because this will advance to the next question before the current one is finished saving. We know that the api is done saving when `is_completed` becomes true. When `hasFeedback` is falsy and the submit button is clicked, `shouldContinue` is set to `true`. If both `shouldContinue` and `is_completed` are true, then the answer has been submitted and saved and it is okay to advance. [CORE-173]
TylerZeroMaster
requested review from
bethshook
and removed request for
a team
bethshook
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://openstax.atlassian.net/browse/CORE-173
Why do it this way?
onAnswerSaveis non-blocking and non-awaitable. Consequently, callingonAnswerSavein the onClick of the submit button does not work because this will advance to the next question before the current one is finished saving.We know that the api is done saving when
is_completedbecomes true.When
hasFeedbackis falsey and the submit button is clicked,shouldContinueis set totrue.Assumption:
If both
shouldContinueandis_completedare true, then the answer has been submitted and saved and it is okay to advance.