Make question-info a heading #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyEJohnson
force-pushed
the
make-question-info-a-heading
branch
from
658dfbc to
a2934a6
Compare
bethshook
reviewed
Dec 10, 2024
| @@ -243,7 +243,7 @@ const StepCard = ({ | |||
| <StepCardHeader> | |||
| <div> | |||
| {leftHeaderChildren} | |||
| <div className="question-info"> | |||
| <div className="question-info" role="heading" aria-level={2}> | |||
There was a problem hiding this comment.
seems like it's preferable to just use a heading tag: https://www.w3.org/WAI/WCAG21/Techniques/aria/ARIA12
There was a problem hiding this comment.
They cite styling as a reason it's preferable, but the reason I didn't use a heading tag was that I didn't want the style to change.
There was a problem hiding this comment.
Native HTML elements have implicit styling and features that won't necessarily be replicated with ARIA equivalents. For instance, heading elements will have specific styling adjustments made when viewing a page in a browser's Reader Mode.
I was more wondering about that second bit but it looks like our iframe doesn't currently render at all in reader mode...
bethshook
approved these changes
Dec 11, 2024
[CORE-418]
RoyEJohnson
force-pushed
the
make-question-info-a-heading
branch
from
a2934a6 to
3921300
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CORE-418