Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aria-label to correct/incorrect icons #80

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Add aria-label to correct/incorrect icons #80

merged 1 commit into from
Dec 10, 2024

Conversation

RoyEJohnson
Copy link
Contributor

@RoyEJohnson RoyEJohnson commented Dec 9, 2024 •
edited by jira bot
Loading

@RoyEJohnson RoyEJohnson requested a review from a team as a code owner December 9, 2024 23:11
@RoyEJohnson RoyEJohnson requested review from bethshook and removed request for a team December 9, 2024 23:11
bethshook
bethshook reviewed Dec 10, 2024
View reviewed changes
src/components/ProgressBar.tsx
@@ -112,6 +114,8 @@ const ItemIcon = ({ variant }: { variant: ProgressBarItemVariant }) => {
color={variantData.color}
height='16px'
width='16px'
aria-label={variantData.label}
aria-hidden={undefined}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

necessary? this is the default

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm I see why you added it

@RoyEJohnson RoyEJohnson merged commit f332eea into main Dec 10, 2024
1 check passed
@RoyEJohnson RoyEJohnson deleted the add-label-to-correctness-marker branch December 10, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bethshook bethshook bethshook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RoyEJohnson @bethshook