Content library and import updates #423
Merged
+4,169
−48,755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dantemss
force-pushed
the
more-content-fixes
branch
from
a43c50e to
2276c02
Compare
|
This PR will allow me to more easily get the book-slug and module-slug tags working for Algebra 1 |
jivey
reviewed
May 6, 2025
| hash.each { |uuid, slugs| slugs.uniq! } | ||
| end | ||
| end | ||
| ) { OpenStax::Content::Abl.new.slugs_by_page_uuid } |
There was a problem hiding this comment.
So this functionality moved inside the gem?
jivey
reviewed
May 6, 2025
| header == 'uuid' || header == 'page uuid' || header == 'section uuid' | ||
| uuid_index ||= headers.index { |header| header&.end_with?('uuid') && !header.include?('book') } | ||
| section_index ||= headers.index do |header| | ||
| header&.start_with?('section') && !header.include?('uuid') && !header.include?('name') |
There was a problem hiding this comment.
Does algebra have slightly different headers? Maybe it's not a worry if we are sure about the imported format, but I just want to double check that loosening the matching is not going to be a concern.
There was a problem hiding this comment.
it was a mess of different headers, let me say that
jivey
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://openstax.atlassian.net/browse/CORE-808