Update dependency versions #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is expected to be reverted. I'm temporarily downgrading the version of msw back to v1 to isolate other dependency update issues so those can be resolved prior to looking into updating to msw v2.
As part of migrating to vite v5, this change: 1. Renames the vite config to use .mts 2. Modifies the playwright configuration to use the webServer setting to launch vite's dev server via shell instead of via API using globalSetup. This is because the file referenced in the globalSetup is required / loaded as CJS.
This reverts commit 38690f5.
This change includes some pretty hacky stuff to enable updating to v2 of the msw library used by some of our tests. The documented migration steps didn't work as adverised so I resorted to applying work arounds discussed in GitHub issues. It's likely some of this may need to get revisited in the future as the approach of the custom jest resolver in particular feels pretty brittle.
|
Tested in my local environment. Looks good! |
P-Gill97
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dependency update PR makes minimal changes to actual application dependencies, but there were major version upgrades to both
viteandmswwhich took a bit of wrangling 😅 . A reviewer may want to walk through the commit history to better understand the scope/motivation behind specific changes. It should also be noted that the version ofundiciwas purposefully not the latest asv6seems to currently be problematic withmsw, and that is the only reason the dependency was added per these docs.