Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user message styles #155

Merged
merged 6 commits into from
Apr 19, 2024
Merged

Add user message styles #155

merged 6 commits into from
Apr 19, 2024

Conversation

P-Gill97
Copy link
Contributor

No description provided.

@P-Gill97 P-Gill97 self-assigned this Apr 18, 2024
Copy link
Contributor

@rnathuji rnathuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some quick comments on this:

  1. Let's make sure to include doc changes similar to here for these new styles so CM has clear examples + corresponding screenshots for reference.
  2. I'm not sure that the CSS as defined here aligns with the usage pattern established by .os-raise-familysupport, but I think it'd be nice if the schema was the same for these two new boxes but just a different class name:
<div class="os-raise-{something}">

</div>
  1. Can we confirm / clarify whether the lightbulb box is going to have links? (the mockup in the issue doesn't seem to have one, but I'm not sure if it's a sometimes or always thing)

@P-Gill97
Copy link
Contributor Author

@rnathuji thoughts on this schema?

<div class="os-raise-usermessage-link">

</div>
<div class="os-raise-usermessage-lightbulb">

</div>

@rnathuji
Copy link
Contributor

I think that works / the class names seem reasonable to me. Tying back to the examples in the mockups they'd look something like:

<div class="os-raise-usermessage-link">
  <p>Use this link to access the activity: <a href="">Desmos Activity: RAISE 3.5.1 Using Bivariate Data in Context</a></p>
</div>
<div class="os-raise-usermessage-lightbulb">
  <p>If you're having trouble seeing the x-intercept, try resizing the graphing window by pressing the '-' button in the upper right hand corner</p>
</div>

@P-Gill97
Copy link
Contributor Author

3. Can we confirm/clarify whether the lightbulb box is going to have links? (the mockup in the issue doesn't seem to have one, but I'm not sure if it's a sometimes or always thing)

@madisonschear said although rare links could end up in the lightbulb message box. I'll give <a> tags in both message boxes the same style.

.os-raise-usermessage-link a, .os-raise-usermessage-lightbulb a {
  text-decoration: underline;
}

@P-Gill97
Copy link
Contributor Author

P-Gill97 commented Apr 18, 2024

@madisonschear I tried to make it look as close as I could to the images in the issue description. Let me know if something seems off.
image

@P-Gill97 P-Gill97 requested review from rnathuji and a team April 18, 2024 23:01
src/styles/content.scss Outdated Show resolved Hide resolved
Comment on lines 503 to 505
.os-raise-usermessage-link a, .os-raise-usermessage-lightbulb a {
text-decoration: underline;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're introducing a bit of asymmetry here as it relates to styling links in these boxes:

image

Can we confirm with UX whether ☝️ is intentional, or if we should be adding .os-raise-familysupport here like:

.os-raise-usermessage-link a,
.os-raise-usermessage-lightbulb a,
.os-raise-familysupport a {
  text-decoration: underline;
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@madisonschear Do we want to add the underline text decoration to the links in the family support box?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes they should be underlined. Thank you @rnathuji good catch!

@P-Gill97 P-Gill97 merged commit de91a88 into main Apr 19, 2024
3 checks passed
@P-Gill97 P-Gill97 deleted the K12-53/add-usermessage-style branch April 19, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants