Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update search component #156

Merged
merged 15 commits into from
May 1, 2024
Merged

update search component #156

merged 15 commits into from
May 1, 2024

Conversation

MReyna12
Copy link
Contributor

No description provided.

@MReyna12 MReyna12 marked this pull request as ready for review April 30, 2024 22:23
@MReyna12 MReyna12 requested a review from a team April 30, 2024 22:23
@MReyna12
Copy link
Contributor Author

I was able to complete most of the items listed here.

A few notes:

  1. I did not add the number of results for each unit. We could probably do it, but you are only supposed to add certain types of content inside of a <button>. I wanted to give it more thought and not rush.
  2. I am open to removing or doing something different as far as displaying Teacher Content and Student Content. I opted for including because it is not always obvious.
  3. When the Teacher Content Only filtering is turned on, the <div>s that previously held the Student Content still exist in the DOM, but they are empty and don't take up space. If this is not ideal, we could revise the way the accordion is rendered. Wanted to flag in case it is something worth discussing.

Happy to discuss decision-making on any items the reviewer may have questions on.

src/styles/bootstrap.scss Show resolved Hide resolved
src/components/SearchBlock.tsx Outdated Show resolved Hide resolved
src/components/SearchBlock.tsx Show resolved Hide resolved
src/components/SearchBlock.tsx Outdated Show resolved Hide resolved
src/components/SearchBlock.tsx Show resolved Hide resolved
src/styles/interactives.scss Outdated Show resolved Hide resolved
src/components/SearchBlock.tsx Outdated Show resolved Hide resolved
@MReyna12 MReyna12 requested a review from rnathuji May 1, 2024 19:39
@MReyna12 MReyna12 merged commit 5ae9926 into main May 1, 2024
3 checks passed
@MReyna12 MReyna12 deleted the K12-61/update-search-component branch May 1, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants