-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency versions #169
Conversation
There were some breaking rule additions in the version update from 52.0.0 to 59.0.0. This change disables most of these new rules for the time being except for @typescript-eslint/no-import-type-side-effects.
This change is due to sass update incorporating the following breaking change: https://sass-lang.com/documentation/breaking-changes/mixed-decls/
@openstax/k12-devs - I'm holding off on marking this ready for review until I have the next batch of dependency update PRs ready, but I wanted to get early 👀 on a couple of things here:
|
Point 1: Totally fine with turning them off at this stage of the game. Point 2: I also agree that these deprecation warnings will have to be addressed by Bootstrap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on local instance. Everything seems to work!
No description provided.