-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partner dates and remove reviews #1584
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm really mostly trusting you here, but it looks ok to me.
is it safe to merge and deploy this with the existing UI?
I know. I'm not sure who else to request reviews from 🤷🏼 There is one change here that will not work with the current frontend - removing the reviews (just noticed the code is still in the FE yesterday). I can pull that into another PR, if you think the CMS should be released before the FE work is done. |
it would be nice to decouple it, if you could at least stub out whatever response the FE is expecting |
Yep, that's what I was thinking. Will do. |
Deployed this to dev. I'm going to check it tomorrow after crons run to make sure everything looks good (ran it manually and it was good), page looks like it works, so I'll merge after that. |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
The major functionality add is the
Partner_Anniversary_Date__c
from Salesforce to support the updated page layout.This also removes the unused partner reviews and pulls some new info in from the Account object to supplement data and start shifting to the Account object over the Solution object for current standing and other account-level info.
Edit: Added partner logo syncing from Salesforce to this PR also.
Edit: The majority of review code has been removed, with endpoints stubbed (similar to how they already were) until the FE can be updated (see comments below).