Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partner dates and remove reviews #1584

Merged
merged 11 commits into from
Oct 17, 2024
Merged

Conversation

mwvolo
Copy link
Member

@mwvolo mwvolo commented Oct 14, 2024

The major functionality add is the Partner_Anniversary_Date__c from Salesforce to support the updated page layout.

This also removes the unused partner reviews and pulls some new info in from the Account object to supplement data and start shifting to the Account object over the Solution object for current standing and other account-level info.

Edit: Added partner logo syncing from Salesforce to this PR also.

Edit: The majority of review code has been removed, with endpoints stubbed (similar to how they already were) until the FE can be updated (see comments below).

@mwvolo mwvolo requested a review from TomWoodward October 14, 2024 18:18
Copy link
Member

@TomWoodward TomWoodward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm really mostly trusting you here, but it looks ok to me.

is it safe to merge and deploy this with the existing UI?

@mwvolo
Copy link
Member Author

mwvolo commented Oct 16, 2024

I know. I'm not sure who else to request reviews from 🤷🏼

There is one change here that will not work with the current frontend - removing the reviews (just noticed the code is still in the FE yesterday). I can pull that into another PR, if you think the CMS should be released before the FE work is done.

@TomWoodward
Copy link
Member

it would be nice to decouple it, if you could at least stub out whatever response the FE is expecting

@mwvolo
Copy link
Member Author

mwvolo commented Oct 16, 2024

Yep, that's what I was thinking. Will do.

@mwvolo
Copy link
Member Author

mwvolo commented Oct 16, 2024

Deployed this to dev. I'm going to check it tomorrow after crons run to make sure everything looks good (ran it manually and it was good), page looks like it works, so I'll merge after that.

@mwvolo mwvolo merged commit 9809e9a into main Oct 17, 2024
2 checks passed
@mwvolo mwvolo deleted the partner-dates-and-remove-reviews branch October 17, 2024 23:22
Copy link

sentry-io bot commented Oct 23, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ SalesforceMalformedRequest: Malformed request {url}. Response content: {content} salesforce.management.commands.update_partners ... View Issue
  • ‼️ SalesforceMalformedRequest: Malformed request {url}. Response content: {content} salesforce.management.commands.update_partners ... View Issue
  • ‼️ ClientError: An error occurred (403) when calling the HeadObject operation: Forbidden salesforce.management.commands.update_partners ... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants