Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code and test to ignore unexpected CSV columns #26

Merged
merged 4 commits into from
Sep 29, 2023
Merged

Update code and test to ignore unexpected CSV columns #26

merged 4 commits into from
Sep 29, 2023

Conversation

P-Gill97
Copy link
Contributor

No description provided.

@P-Gill97 P-Gill97 self-assigned this Sep 28, 2023
@P-Gill97
Copy link
Contributor Author

@rnathuji In the CI job this step is failing 🤔 I think the docker hub registry is having some issues. I will rerun this tomorrow.

Run docker compose up -d postgres
 postgres Pulling 
 postgres Error 
Error response from daemon: Get "https://registry-1.docker.io/v2/": net/http: request canceled (Client.Timeout exceeded while awaiting headers)
Error: Process completed with exit code 18.

rnathuji
rnathuji reviewed Sep 29, 2023
View reviewed changes
tests/test_course_content_loader.py Outdated Show resolved Hide resolved
loaders/course_content_loader.py Show resolved Hide resolved
loaders/course_content_loader.py Outdated Show resolved Hide resolved
loaders/course_content_loader.py Outdated Show resolved Hide resolved
@P-Gill97 P-Gill97 requested a review from rnathuji September 29, 2023 18:05
@P-Gill97 P-Gill97 merged commit 23cc382 into main Sep 29, 2023
@P-Gill97 P-Gill97 deleted the k12-505/update-code-to-ignore-unexpected-columns branch September 29, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnathuji rnathuji rnathuji approved these changes

Assignees

@P-Gill97 P-Gill97

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@P-Gill97 @rnathuji