Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update highlight popup text on mobile #2386

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+4 −4
Open

Update highlight popup text on mobile #2386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e8b12d
Update highlight popup text on mobile
RoyEJohnson Jan 14, 2025
e5f9418
Update snapshot
RoyEJohnson Jan 14, 2025
a0889ac
Fix Spanish translation
RoyEJohnson Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...content/highlights/components/SummaryPopup/__snapshots__/HighlightsHelpInfo.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ exports[`HighlightsHelpInfo matches snapshot when showed 1`] = `
<span
dangerouslySetInnerHTML={
Object {
"__html": "Need help? Visit the <a data-testid='support-link' data-analytics-label='support-link' target=\\"_blank\\" href=\\"https://help.openstax.org/s/article/Using-the-highlighting-and-note-taking-feature-on-mobile-or-tablet?search=highlighting\\">Support Center</a>",
"__html": "Notes and highlights cannot be edited on mobile devices. <a data-testid='support-link' data-analytics-label='support-link' target=\\"_blank\\" href=\\"https://help.openstax.org/s/article/Using-the-highlighting-and-note-taking-feature-on-mobile-or-tablet?search=highlighting\\">Read more</a>",
}
}
/>
Expand Down
2 changes: 1 addition & 1 deletion src/app/messages/en/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@
"i18n:toolbar:highlights:popup:heading": "My Highlights and Notes",
"i18n:toolbar:highlights:popup:heading:no-highlights": "No results.",
"i18n:toolbar:highlights:popup:heading:no-highlights-tip": "Try selecting different <strong>chapter or color filters</strong> to see different results.",
"i18n:toolbar:highlights:popup:help-info": "Need help? Visit the <a data-testid='support-link' data-analytics-label='support-link' target=\"_blank\" href=\"https://help.openstax.org/s/article/Using-the-highlighting-and-note-taking-feature-on-mobile-or-tablet?search=highlighting\">Support Center</a>",
"i18n:toolbar:highlights:popup:help-info": "Notes and highlights cannot be edited on mobile devices. <a data-testid='support-link' data-analytics-label='support-link' target=\"_blank\" href=\"https://help.openstax.org/s/article/Using-the-highlighting-and-note-taking-feature-on-mobile-or-tablet?search=highlighting\">Read more</a>",
"i18n:toolbar:highlights:text": "Highlights",
"i18n:toolbar:practice-questions:button:text": "Practice",
"i18n:toolbar:print:aria-label": "print",
Expand Down
2 changes: 1 addition & 1 deletion src/app/messages/es/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@
"i18n:toolbar:highlights:popup:heading": "Mis textos resaltados y notas",
"i18n:toolbar:highlights:popup:heading:no-highlights": "No hay resultados.",
"i18n:toolbar:highlights:popup:heading:no-highlights-tip": "Intente seleccionar diferentes <strong> filtros de color o de capítulo </strong> para ver diferentes resultados.",
"i18n:toolbar:highlights:popup:help-info": "¿Necesita ayuda? Visite <a data-testid='support-link' data-analytics-label='support-link' target=\"_blank\" href=\"https://help.openstax.org/s/article/Using-the-highlighting-and-note-taking-feature-on-mobile-or-tablet?search=highlighting\">Support Center</a>",
"i18n:toolbar:highlights:popup:help-info": "Las notas y los textos resaltados no se pueden editar en dispositivos móviles. <a data-testid='support-link' data-analytics-label='support-link' target=\"_blank\" href=\"https://help.openstax.org/s/article/Using-the-highlighting-and-note-taking-feature-on-mobile-or-tablet?search=highlighting\">Leer más</a>",
"i18n:toolbar:highlights:text": "Textos resaltados",
"i18n:toolbar:practice-questions:button:text": "Práctica",
"i18n:toolbar:print:aria-label": "Imprimir",
Expand Down
2 changes: 1 addition & 1 deletion src/app/messages/pl/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@
"i18n:toolbar:highlights:popup:heading": "Moje notatki i zakreślenia",
"i18n:toolbar:highlights:popup:heading:no-highlights": "Brak wyników",
"i18n:toolbar:highlights:popup:heading:no-highlights-tip": "Wybierz inny <strong>rozdział albo kolor</strong>, żeby zobaczyć inne wyniki.",
"i18n:toolbar:highlights:popup:help-info": "Potrzebujesz pomocy? Przejdź do <a data-testid='support-link' data-analytics-label='support-link' target=\"_blank\" href=\"https://help.openstax.org/s/article/Using-the-highlighting-and-note-taking-feature-on-mobile-or-tablet?search=highlighting\">Support Center</a>",
"i18n:toolbar:highlights:popup:help-info": "Notatek i wyróżnień nie można edytować na urządzeniach mobilnych. <a data-testid='support-link' data-analytics-label='support-link' target=\"_blank\" href=\"https://help.openstax.org/s/article/Using-the-highlighting-and-note-taking-feature-on-mobile-or-tablet?search=highlighting\">Przeczytaj więcej</a>",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ewaforman Please check this translation of "Notes and highlights cannot be edited on mobile devices. Read more"

"i18n:toolbar:highlights:text": "Notatki",
"i18n:toolbar:practice-questions:button:text": "Ćwiczenia",
"i18n:toolbar:print:aria-label": "Drukuj",
Expand Down
Loading