Fixed windows scancodes #1697
Merged
Fixed windows scancodes #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backspace, page up, and page down had the wrong scancodes, according to internet and testing
|
Thank you @Erhannis for opening this PR! I used your PR to test if our GitHub Actions are still working. Looks like there are some issues around packaging and a deprecated macOS version. Both not related to your PR of course. I'll try to get that fixed in another PR. |
mkrnr
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows backspace, page up, and page down had the wrong scancodes, according to internet and testing
Summary of changes
Windows: fixed backspace scancode and swapped page up/down.
I checked all the non-character scancodes against a list, they all seem right, now.
Closes #1444 probably
Pull Request Checklist