Set reasonable PostgreSQL GUCs for tile servers #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is a GUC exactly? |
tomhughes
reviewed
Sep 12, 2023
| :work_mem => "128MB", | ||
| :maintenance_work_mem => "8GB", |
There was a problem hiding this comment.
This is also currently configured on a per-server basis.
There was a problem hiding this comment.
We've got cases where it's configured both on a role level and a server level. I'll remove the setting of it for many of the servers where the defaults make sense.
PostgreSQL configuration parameter |
tomhughes
reviewed
Sep 14, 2023
| @@ -21,8 +21,6 @@ | |||
| :postgresql => { | |||
| :settings => { | |||
| :defaults => { | |||
| :shared_buffers => "8GB", | |||
| :maintenance_work_mem => "7144MB", | |||
There was a problem hiding this comment.
If we're going to drop this from the per-server configuration do we not want to add a shared setting? Otherwise it will drop to the 64Mb default?
There was a problem hiding this comment.
Looks like a rebase mistake wiped out that change
There was a problem hiding this comment.
Looks like a rebase mistake wiped out that change
These are based off of the osm2pgsql.org recommendations, scaled for the larger servers we run, as well as experience running PostgreSQL in a large variety of environments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are based off of the osm2pgsql.org recommendations, scaled for the larger servers we run, as well as experience.
This should be merged after #613 and apply cleanly. If it doesn't apply cleanly, I'll rebase.