Create a new vectortile role #686
Conversation
| property :owner, :kind_of => String, :required => [:create] | ||
| property :permissions, :kind_of => Hash, :default => {} | ||
|
|
||
| action :create do |
There was a problem hiding this comment.
I'm not happy with the complexity of this. Schemas are per-DB and created by chef with access permissions. This is different than other resources. Tablespaces are clusterwide and created with chef while tables are per-db and not created by chef.
|
ping @Firefishy |
|
I'm probably better placed to review this... I'll try and get to it over the weekend. |
cookbooks/vectortile/templates/default/tilekiln-storage-update.erb
Outdated
Show resolved
Hide resolved
cookbooks/vectortile/templates/default/tilekiln-storage-init.erb
Outdated
Show resolved
Hide resolved
|
I believe all issues have been fixed. |
|
Is it better to merge this in large chunks like this one, or wait till a machine is assigned and then merge it and assign the machine the appropriate role? |
I don't mind when it's merged but I'd rather not have it amended once it's been reviewed - better to merge it and make changes in additional PRs as it's easier to review additional changes than have to re-review a big change like this because it's been updated. |
pnorman
force-pushed
the
vectortile
branch
3 times, most recently
from
c265a37 to
28a07fc
Compare
|
28a07fc is ready for review. |
|
I think everything is good here. I've rebased on master and I'm successfully keeping the DB up to date and generating vector tiles |
| Disallow: /20/ | ||
| Disallow: /21/ | ||
| Disallow: /22/ | ||
| Disallow: /23/ |
There was a problem hiding this comment.
Is this right for vector tiles?
There was a problem hiding this comment.
Zoom levels 20+ don't exist for our raster or vector tiles. I assumed they were added to robots.txt because people were requesting them, and the same could happen with vector tiles.
|
The test failures are in db-base, master, and slave and seem unrelated to this PR. |
This role is for tilekiln vector tile servers and it currently sets up and starts tilekiln and has the scripts necessary to import data.
It's getting long enough that I'd like a review