-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add streetview.vn service for Data Photo layer #10585
base: develop
Are you sure you want to change the base?
Conversation
Buminta
commented
Dec 5, 2024
- We're added more Photo Layer Data with Streetview.vn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Source code good. Has an ignore ctags file for gitignore
Hi @Buminta, thanks for your contribution. Can you provide more details about Streetview.vn? It seems to be related to openmap-vn, correct? In order for iD to integrate with Streetview.vn’s street-level imagery, there needs to be something in writing that explicitly gives OSM contributors the right to use the photos. For reference, see #9664, where another company also wanted to integrate their service but first needed to tweak their terms of use for compatibility with OSM. Chào @Buminta, cám ơn anh soạn đóng góp này. Anh có thể cho biết thêm chi tiết về Streetview.vn không? Có lẽ nó liên quan đến tài khoản openmap-vn phải không? Để tích hợp dịch vụ hình ảnh này vào iD, Streetview.vn cần phải ghi rõ rằng những người đóng góp vào OSM được phép sử dụng các hình ảnh. Xin tham khảo #9664, hồi đó có một công ty khác cũng muốn tích hợp dịch vụ của họ nhưng cần phải chỉnh lại các điều khoản sử dụng trước tiên để phù hợp với OSM. |
@1ec5 exe. Thanks for review. Please for merged |
@1ec5 Please review and merged for us! Thanks so much. |
@Buminta I'll take a look at this PR in the coming days. Thanks for your patience. |
I don't think the license agreement is documented well enough for this to get merged.
This page does not mention the search term "openstreetmap". I also don't find any mention of the project on the wiki. I would expect two things
I think we should pick a name that references the service better than "streetview" in our codebase. Something like "streetview-vietnam" maybe? I think the goal should be that in the code we can easily spot regional services vs. global services. There is still the issue that "Street View" is a trademark by Google and they did force companies to change this name before, like with Kartaview |