Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue Merging two ways corrupts step_count #10492 #10633

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Darshit42
Copy link

@Darshit42 Darshit42 commented Dec 28, 2024

this pr fixes issue #10492 ,changes are such that it adds up the values of tags

before fixing the issue tags such as step_count , parking:left, etc values were not adding up when lines were merged, this creates confusion to user on how merging works
merging two ways resulted in 3+4 => Error (values are not same) or 2+2 => 2 (values are not summed)

after this , when lines are merged it adds up the values of tags successfully
merging two ways resulted in 3+4 => 7

Screen-Recording.mp4

@Darshit42 Darshit42 changed the title fixed issue 10492 fixed issue #10492 Dec 28, 2024
@Darshit42
Copy link
Author

to anyone who's reading this , if i made any mistakes in raising this pr feel free to criticize it's my first time raising a pr in other repo besides mine 🙃

@Darshit42 Darshit42 changed the title fixed issue #10492 fixed issue Merging two ways corrupts step_count #10492 Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant