Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add swingerclub #1187

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add swingerclub #1187

wants to merge 6 commits into from

Conversation

Asteliks
Copy link

@Asteliks Asteliks commented Apr 2, 2024

Solves issue #1186

Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey. Usage is relatively low, but I guess it would be reasonable to include this as a preset, so that these amenities are not mistakenly mapped as strip clubs or the like.

Only one suggestion: I'm not sure if the fas-cocktail icon is a good fit here. Maybe a better icon would be something like maki-heart (used by the Love Hotel preset already) or fas-venus-mars?

data/presets/amenity/swingerclub.json Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Apr 5, 2024

🍱 You can preview the tagging presets of this pull request here.

@Asteliks
Copy link
Author

Asteliks commented Apr 6, 2024

Hi, thanks for the fix. Also good point maki-heart seems best. I will change it as soon as I can

@Asteliks
Copy link
Author

@tyrasd is there anything else I need to do for us to merge this?

@Asteliks
Copy link
Author

@tyrasd I see that your back again. I hope that everything is good on your side! Just wanted to bump this one. As a side note could I become a contributor here too? I do my work for Poland, and used to do most of the stuff here: https://github.com/osmlab/editor-layer-index

@Asteliks Asteliks requested a review from tyrasd June 1, 2024 12:49
@Asteliks
Copy link
Author

Hi @tordans, could I ask you to help me out with this PR? @tyrasd seems to be unavailable

@Asteliks
Copy link
Author

Hello @tyrasd @tordans,

It feels like I'm being ghosted. The last input I received from you was back on April 11th. That is approximately 3 months ago. It’s somewhat painful to be left waiting for such an extended period. Please review this PR and provide feedback if there is something that requires fixing.

Could we discuss what I can do to improve your responsiveness and avoid such long waiting times in the future? I believe quicker communication would be beneficial for everyone involved. Thank you for your attention to this matter.

Best regards,
Asteliks

@tordans
Copy link
Collaborator

tordans commented Jul 11, 2024

Hey @Asteliks, I share your frustration. It is part of why I am working on setting up processes to have the iD projects supported by more community input. See the "Docs:*" PRs in https://github.com/openstreetmap/id-tagging-schema/pulls/tordans

Could we discuss what I can do to improve your responsiveness and avoid such long waiting times in the future? I believe quicker communication would be beneficial for everyone involved. Thank you for your attention to this matter.

A thing that would help ATM to get feedback on the docs.
You can also ping me on https://slack.openstreetmap.us/ or Matrix to talk about it.

As a side note could I become a contributor here too?

Personally, I thing it would be great to have more people helping out.
A good place to start will be to join the next https://wiki.openstreetmap.org/wiki/ID/Community_Chats so we can get to know each other better.

I do my work for Poland

Side note: Will you be at the SOTM EU? If so, lets say hi…


On this preset: I know nothing about the tagging schema involved so it's time consuming for me to form an optinion.
What would help is, if you took the piece of the proposed PR template https://github.com/openstreetmap/id-tagging-schema/pull/1239/files#diff-18813c86948efc57e661623d7ba48ff94325c9b5421ec9177f724922dd553a35R27-R59 and shared the result. The general idea is to have screenshots and links in the PR that make reviewing easier. Looking at this preset but also how it interacts with others (like in search).

@Asteliks
Copy link
Author

@tordans I've reviewed your PRs and given comments where I could. Visiting SOTM Łódź is tempting but my budget it tight right now but I still might find a way there. Come to think about the PR template we may add a check list to it so the user checks the PR before asking for a review. We can use the task list feature of markdown:

  • Are the fields well-structured and have good labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants