-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add swingerclub #1187
base: main
Are you sure you want to change the base?
Add swingerclub #1187
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey. Usage is relatively low, but I guess it would be reasonable to include this as a preset, so that these amenities are not mistakenly mapped as strip clubs or the like.
Only one suggestion: I'm not sure if the fas-cocktail
icon is a good fit here. Maybe a better icon would be something like maki-heart
(used by the Love Hotel preset already) or fas-venus-mars
?
🍱 You can preview the tagging presets of this pull request here. |
Hi, thanks for the fix. Also good point |
@tyrasd is there anything else I need to do for us to merge this? |
@tyrasd I see that your back again. I hope that everything is good on your side! Just wanted to bump this one. As a side note could I become a contributor here too? I do my work for Poland, and used to do most of the stuff here: https://github.com/osmlab/editor-layer-index |
It feels like I'm being ghosted. The last input I received from you was back on April 11th. That is approximately 3 months ago. It’s somewhat painful to be left waiting for such an extended period. Please review this PR and provide feedback if there is something that requires fixing. Could we discuss what I can do to improve your responsiveness and avoid such long waiting times in the future? I believe quicker communication would be beneficial for everyone involved. Thank you for your attention to this matter. Best regards, |
Hey @Asteliks, I share your frustration. It is part of why I am working on setting up processes to have the iD projects supported by more community input. See the "Docs:*" PRs in https://github.com/openstreetmap/id-tagging-schema/pulls/tordans
A thing that would help ATM to get feedback on the docs.
Personally, I thing it would be great to have more people helping out.
Side note: Will you be at the SOTM EU? If so, lets say hi… On this preset: I know nothing about the tagging schema involved so it's time consuming for me to form an optinion. |
@tordans I've reviewed your PRs and given comments where I could. Visiting SOTM Łódź is tempting but my budget it tight right now but I still might find a way there. Come to think about the PR template we may add a check list to it so the user checks the PR before asking for a review. We can use the task list feature of markdown:
|
Solves issue #1186