-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not enforce Cycle & Foot Path or Cycle & Foot Crossing in Norway #1193
base: main
Are you sure you want to change the base?
Conversation
…NO) due to the NO community not applying bicycle=designated on highway=cycleway Also fix an apparent bug in that DE is excluded from Cycle & Foot Path, but not from Cycle & Foot Crossing.
FYI we discussed an update path to the current crossing presets during the last iD community meetup. This hat not been properly documented nor implemented, though. I think we should first work on this cleanup before adding more complexity on top of it. |
I'm sorry, I'm not sufficiently involved in the iD community to understand what you wrote. However, the change I'm proposing doesn't appear to add any complexity. I'm just adding another country to an existing list of countries. Could you explain the added complexity? |
It's a relatively straight-forward change, so I imagine the review will be quick and simple. I don't know the process to move this forward. Is there something that needs to be done? |
@@ -4,8 +4,10 @@ | |||
"fr", | |||
"lt", | |||
"pl", | |||
"de", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I created #1204 to improve this situation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. Does that mean there's progress on this PR as well?
Any progress on approving this? It's quite simple, and it seems it's already been reviewed. |
For me, this is the kind of PR I would like @tyrasd to review and merge. I was also hoping for #1201 to be merged first and then apply this change on top of it. But the other way around is possible to, of course. |
I don't mind who reviews it. Having tagged someone who can or should will hopefully speed this up. Thank you. |
Do not enforce Cycle & Foot Path or Cycle & Foot Crossing in Norway (NO) due to the NO community not applying bicycle=designated on highway=cycleway. See https://wiki.openstreetmap.org/wiki/No:Map_Features#Sykkel for reference.
Also fix an apparent bug in that DE is excluded from Cycle & Foot Path, but not from Cycle & Foot Crossing.