-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add strings for house=
field and disable Taginfo suggestions
#1412
base: main
Are you sure you want to change the base?
Conversation
🍱 You can preview the tagging presets of this pull request here. |
data/fields/house.json
Outdated
"options": { | ||
"bungalow": "Bungalow", | ||
"detached": "Detached House", | ||
"link-detached": "Link-Detached House", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
house=link-detached
has only ~750 uses and less than 20 in the building
key. There isn't a preset for it in iD. It is documented though, so it might be a good idea to create a preset.
house=
field and disable Taginfo suggestions
FYI: I looked into houses in #1155 when I tried to understand the different wording in SC vs iD vs Wiki but never finished it. |
@Dimitar5555 I think this is a good addition. But we need to make sure we are not missing something relevant and make the situation worse for some cases. Could you double check that we have all values in this list that StreetComplete uses? And we should also check document the taginfo most used values so we support any that are used often, like maybe 5k+? |
Btw, a great follow up to this would be to create small icons for those values like we have for crossings. Those are supported via And once openstreetmap/iD#10613 is done and we have a better display of the value |
Note that SC is using the SC seems to be missing an answer for terraced houses. SC is treating P.S. Whether SC should be using
✅
It is a good suggestion in principle but I'm not sure how they could look.
I will add it in the coming days (or maybe next year 😄). |
Ah, sorry, I did not fully realize, what we are actually looking at here … So this list is only used for the (Side note: There is no other usage of this field https://github.com/search?q=repo%3Aopenstreetmap%2Fid-tagging-schema+%5C%22house%5C%22+path%3A%2F%5Edata%5C%2Fpresets%5C%2F%2F&type=code ) FYI: We have three unsearchable presets for specific values of this list in https://github.com/openstreetmap/id-tagging-schema/tree/main/data/presets/building/house which where all added in #921 – those unsearchable presets don't have " TBH I am not sure if we actually want those separate, unsearchable presets. The only benefit I can see is that https://github.com/openstreetmap/id-tagging-schema/pull/921/files#diff-cb5181126156c42a37b82bff9e25d5bf13d6c2b4331b6980a24262ceaf8b2c06R2 has a different icon now.
The question for this repo that I see from this is: How can we make those sub-types discoverable when searching or browsing for houses in iD. Right now only https://github.com/openstreetmap/id-tagging-schema/blob/main/data/presets/building/detached.json will be findable but https://github.com/openstreetmap/id-tagging-schema/blob/main/data/presets/building/house/_detached.json will be hidden from the search and browser section. Again, this is something we don't have to solve now, but we might want to create a follow up issue for this to see if there is a solution for it. Right now it looks like conflicting tagging practices that we cannot really resolve(?) |
Test-DocumentationFind test cases: https://overpass-turbo.eu/s/1Wan
Preview links & Sidebar ScreenshotsSearchJust to document the "two tagging standards" issue described above: This find the Info-
|
Done.
Updated accordingly.
I skipped this value on purpose. It isn't clear to me what it means. Is it |
Description, Motivation & Context
Currently the
house
field doesn't have any strings and it shows any value with 100+ uses. This creates a lot of variants for tagging the same thing.This PR introduces strings for the documented values of
house=
tag and disables Taginfo's suggestions for the field.P.S. It doesn't affect the tag editor, I'm not sure if we can influence it.
Related issues
None
Links and data
Relevant OSM Wiki links:
https://wiki.openstreetmap.org/wiki/Key:house
Relevant tag usage stats:
https://taginfo.openstreetmap.org/keys/house#values
Checklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.