Add 'tag deleted successfully' flash message

openstreetmap · Nov 9, 2024 · 3c06e24 · 3c06e24
1 parent 974366a
commit 3c06e24
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 0 deletions.
diff --git a/app/controllers/changeset_tags_controller.rb b/app/controllers/changeset_tags_controller.rb
@@ -34,6 +34,7 @@ def delete
     end
 
     @changeset_tag.delete
+    flash[:notice] = t ".success", :k => @changeset_tag.k, :v => @changeset_tag.v
     redirect_to changeset_tags_path(@changeset)
   end
 end
diff --git a/config/locales/en.yml b/config/locales/en.yml
@@ -453,6 +453,8 @@ en:
     tag_not_found:
       heading: Changeset tag does not exist
       body: "Sorry, tag %{k} could not be found in changeset #%{id}."
+    delete:
+      success: Tag %{k}=%{v} deleted successfully.
   changesets:
     changeset:
       no_edits: "(no edits)"

diff --git a/test/controllers/changeset_tags_controller_test.rb b/test/controllers/changeset_tags_controller_test.rb
@@ -124,6 +124,7 @@ def test_delete_success
       assert_redirected_to changeset_tags_path(changeset)
     end
     assert_equal({ "tested-2nd-tag-key" => "tested-2nd-tag-value" }, changeset.tags)
+    assert_match(/tested-1st-tag-key=tested-1st-tag-value deleted successfully/, flash[:notice])
   end
 
   def test_delete_success_empty_tag