Accessibility issue: links "click here"

[maro-21]

Copy from Translatewiki:

The current message text is:

• Confirmations.confirm.resend html: If you need us to resend the confirmation email, %{reconfirm_link}.
• Confirmations.confirm.click here: click here

For accessibility, “click here” should never be a link text, because the link text should always describe the link. A more accessible version of these messages would be:

• Confirmations.confirm.resend html: If needed, we can %{reconfirm_link} to you.
• Confirmations.confirm.click here: resend the confirmation email

Rationale from the W3C: Many blind people who use screen readers call up a dialog box that has a list of links from the page. They use this list of links to decide where they will go. But if many of the links in that list simply say "click here" or "more" they will be unable to use this feature in their screen reader, which is a core navigation strategy. That's why it's a failure of 2.4.9 to not provide any way of allowing them to know the destination from the link text alone. It is also true for people who tab through links. If all they hear as they tab through the document is "click here, click here, click here etc." they will become confused.

[peach280]

I have generated a PR to fix this issue. Please review and provide your valuable feedback

[tomhughes]

In reality nobody should ever see that version of the page - the only way that is ever rendered is if you somehow arrive at the confirm link without a token parameter in the URL which should never happen.

[AntonKhorev]

I have generated

Generated with what?

[AntonKhorev]

In reality nobody should ever see that version of the page - the only way that is ever rendered is if you somehow arrive at the confirm link without a token parameter in the URL which should never happen.

It happens after you fill out the signup from and click "Sign Up". We should probably remove redirects/renders from save_new_user in users controller to make it more clear.