Replace resent confirmation link with button #5447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonKhorev
force-pushed
the
confirm-resend-button
branch
from
cde73ae to
fcfb7d4
Compare
|
This depends on #5446 being merged first. |
|
Looks good to me, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #5446
There's an issue that the resend confirmation email link reads "click here" #5431. I think there shouldn't be any link at all, this should be a button because it does something, not just loads a page. And the page shouldn't be accessible by GET, the button should trigger POST. When you accept the confirmation link, there's also a button which posts, but its hidden and autoclicked by javascript. The current resend link+GET existed since bddf524.
Fixes #5431 by not having a link, and not writing "click here" on a button.